New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Change qml.equal
default behaviour to return False
instead of raising error
#4315
Conversation
[sc-40553] |
Codecov Report
@@ Coverage Diff @@
## master #4315 +/- ##
=======================================
Coverage 99.79% 99.79%
=======================================
Files 351 351
Lines 32058 32108 +50
=======================================
+ Hits 31991 32041 +50
Misses 67 67
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
my previous approval stands
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me, thanks @mudit2812 ! 🚀
Description of the Change:
qml.equal
and dispatches to remove any errors that are raised and replace them withreturn False
.Benefits:
qml.equal
doesn't break code execution. Users no longer need to usetry-except
blocks to rely onqml.equal
without raising errors.Possible Drawbacks:
Related GitHub Issues: