New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upgrade qchem to use fermionic operators #4336
Conversation
Hello. You may have forgotten to update the changelog!
|
Codecov Report
@@ Coverage Diff @@
## master #4336 +/- ##
=======================================
Coverage 99.77% 99.77%
=======================================
Files 351 351
Lines 32411 32435 +24
=======================================
+ Hits 32338 32362 +24
Misses 73 73
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @soranjh! Looks like things are working and the demo notebooks run without warnings. 🚀
I left a few comments/questions, and I was wondering if a few more tests would be in order :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @soranjh! Please could you add an entry to the deprecations page, as I've realized that this upgrade effectively contains a deprecation of the old behaviour.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just some small changes, looks good overall.
Since we are deprecating the default functionality, we should also make sure to test that the warnings we raise are actually being raised. This might be a bit overkill as the warning will be removed soon aswell, but shouldn't take too long
Added tests for warnings. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me! Thanks @soranjh 🚀
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me!
[SC-39865] |
Context:
The
qchem
module is upgraded to use the fermionic operators of thefermi
module.Description of the Change:
The function
fermionic_observable
is modified to optionally return aFermiSentence
.The function
qubit_observable
is modified to optionally accept aFermiSentence
as input.Benefits:
Possible Drawbacks:
Related GitHub Issues: