-
Notifications
You must be signed in to change notification settings - Fork 569
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[BUG FIX] Add support for adjoint operations in default.qutrit
#4348
Conversation
[sc-41682] |
default.qutrit
default.qutrit
I tested the changes where I originally found the issue and this PR has fixed what I originally encountered. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
could you add an integration test that shows the case from the original bug report to prove with certainty that it works (with a default.qutrit qnode)? otherwise lgtm!
Co-authored-by: Matthew Silverman <matthews@xanadu.ai>
Codecov Report
@@ Coverage Diff @@
## master #4348 +/- ##
=======================================
Coverage 99.79% 99.79%
=======================================
Files 351 351
Lines 32109 32112 +3
=======================================
+ Hits 32042 32045 +3
Misses 67 67
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me :)
Context:
Many non-parametric qutrit operations don't have available adjoints in PennyLane, because of which using
qml.adjoint
with these operations was not working withDefaultQutrit
.Description of the Change:
Adjoint(op)
to list of supported operations inDefaultQutrit
for non-parametric qutrit operations.Benefits:
Adjoint operations work correctly on
DefaultQutrit
.Possible Drawbacks:
Related GitHub Issues:
#4347