Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drop python 3.8 & update Jax to 0.4.14 #4453

Merged
merged 13 commits into from Aug 11, 2023
Merged

Drop python 3.8 & update Jax to 0.4.14 #4453

merged 13 commits into from Aug 11, 2023

Conversation

rmoyard
Copy link
Contributor

@rmoyard rmoyard commented Aug 9, 2023

Description of the Change:

  • Remove python 3.8
  • Update Jax version on the CI checks.

@github-actions
Copy link
Contributor

github-actions bot commented Aug 9, 2023

Hello. You may have forgotten to update the changelog!
Please edit doc/releases/changelog-dev.md with:

  • A one-to-two sentence description of the change. You may include a small working example for new features.
  • A link back to this PR.
  • Your name (or GitHub username) in the contributors section.

@rmoyard rmoyard changed the title Update Jax to 0.4.14 Drop python 3.8 & update Jax to 0.4.14 Aug 9, 2023
@rmoyard
Copy link
Contributor Author

rmoyard commented Aug 9, 2023

[sc-37949]

@codecov
Copy link

codecov bot commented Aug 9, 2023

Codecov Report

Merging #4453 (893d43e) into master (5495875) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master    #4453   +/-   ##
=======================================
  Coverage   99.77%   99.77%           
=======================================
  Files         371      371           
  Lines       33910    33910           
=======================================
  Hits        33834    33834           
  Misses         76       76           

Copy link
Contributor

@mudit2812 mudit2812 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Romain! Could you open a PR on the pennylane.ai-react repo with the update as well? You can see an example here https://github.com/XanaduAI/pennylane.ai-react/pull/371

@albi3ro albi3ro requested a review from mlxd August 10, 2023 14:35
@mlxd
Copy link
Member

mlxd commented Aug 11, 2023

Hey @rmoyard, since the docs-builder also installs PennyLane under 3.8, can you update the python version there too to 3.9?

Once this goes through I'll update the expected CI requirements in the repo

Copy link
Member

@mlxd mlxd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @rmoyard !

@rmoyard rmoyard enabled auto-merge (squash) August 11, 2023 14:31
@rmoyard rmoyard merged commit 4e911cf into master Aug 11, 2023
40 checks passed
@rmoyard rmoyard deleted the update_jax_14 branch August 11, 2023 15:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants