-
Notifications
You must be signed in to change notification settings - Fork 568
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for offset in qml.MPS
template
#4531
Conversation
[sc-37759] |
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## master #4531 +/- ##
=======================================
Coverage 99.64% 99.64%
=======================================
Files 376 376
Lines 33238 33249 +11
=======================================
+ Hits 33119 33130 +11
Misses 119 119
☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A nice improvement of qml.MPS
🚀 🚀
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @obliviateandsurrender!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me. Approved as soon as the merge conflict are resolves 👍
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
just a few nitpicks but it all looks great! 🎉 if you can make the _unflatten
code work without upsetting pylint by just creating an op normally, that would be cool 😎 if not, no worries
**Context:** `qml.MPS` allows users to create MPS circuits according to the paper [Towards Quantum Machine Learning with Tensor Networks](https://arxiv.org/abs/1803.11537). But users would like to have more flexibility in controlling the tensor-network connectivity. **Description of the Change:** Adds a new keyword argument `offset` that allows users to change position of subsequent block from the standard `n_block_wires/2` **Benefits:** Makes the template more flexible **Possible Drawbacks:** N/A **Related GitHub Issues:** [Forum Discussion](https://discuss.pennylane.ai/t/qml-mps-offset-control/2890)
Context:
qml.MPS
allows users to create MPS circuits according to the paper Towards Quantum Machine Learning with Tensor Networks. But users would like to have more flexibility in controlling the tensor-network connectivity.Description of the Change: Adds a new keyword argument
offset
that allows users to change position of subsequent block from the standardn_block_wires/2
Benefits: Makes the template more flexible
Possible Drawbacks: N/A
Related GitHub Issues: Forum Discussion