Update op and MP __eq__ and __hash__
#4536
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mudit2812
commented
Aug 28, 2023
|
I now fear that some of the changes I made last release were unnecessary... can we (I?) take a sec to see if any can be safely un-done in this PR? |
albi3ro
reviewed
Aug 28, 2023
|
[sc-36545] [sc-36546] |
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## master #4536 +/- ##
==========================================
- Coverage 99.65% 99.65% -0.01%
==========================================
Files 376 376
Lines 33114 33104 -10
==========================================
- Hits 33001 32991 -10
Misses 113 113
☔ View full report in Codecov by Sentry. |
timmysilv
approved these changes
Aug 29, 2023
albi3ro
approved these changes
Aug 30, 2023
|
Progress has stalled a bit. Going to re-request review after updating docs and reverting any unnecessary changes that @timmysilv and I added before the 0.32 release. |
timmysilv
approved these changes
Aug 31, 2023
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context:
Operator and measurement process hash and equality have been pending changes.
Description of the Change:
__eq__to returnqml.equal.__hash__to return thehashproperty of the object.Benefits:
Equality and hashing makes sense.
Possible Drawbacks:
Related GitHub Issues: