-
Notifications
You must be signed in to change notification settings - Fork 569
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add wires to device api #4538
Add wires to device api #4538
Conversation
Hello. You may have forgotten to update the changelog!
|
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## master #4538 +/- ##
=======================================
Coverage 99.66% 99.66%
=======================================
Files 376 376
Lines 33060 33070 +10
=======================================
+ Hits 32950 32960 +10
Misses 110 110
☔ View full report in Codecov by Sentry. |
I think codecov is comparing against the wrong base? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
All things old are new again. But at least optional 🤷
Context:
The new device API does not currently accept wires, but users (and thousands, if not millions of tests) have grown to expect it.
Description of the Change:
dev.wires
will be NoneBenefits:
qml.state()
+ DQ2 improvements coming soonPossible Drawbacks:
N/A