New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add single MeasurementValue
support to measurement processes
#4544
Conversation
Hello. You may have forgotten to update the changelog!
|
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## master #4544 +/- ##
=======================================
Coverage 99.62% 99.63%
=======================================
Files 375 375
Lines 33486 33536 +50
=======================================
+ Hits 33362 33412 +50
Misses 124 124
☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looking super good! I think there are just some remnant of the old implementation, but otherwise it's shaping up 👍
Co-authored-by: Matthew Silverman <matthews@xanadu.ai>
Co-authored-by: Matthew Silverman <matthews@xanadu.ai>
Co-authored-by: Matthew Silverman <matthews@xanadu.ai>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
one last concern, but otherwise this looks ready to roll!
Co-authored-by: Matthew Silverman <matthews@xanadu.ai>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🎉 thanks for addressing all my questions! I am now realizing that the repr for a MeasurementProcess
with a MeasurementValue
(and the repr for those too) could use some work, but we can do it in another PR to get this one merged rn
Context:
PR 1 for adding support for collecting statistics for mid-circuit measurements. This PR adds support for single measurement values. Supported devices are
default.qubit
,default.mixed
, andDefaultQubit2
. Supported measurement processes areqml.expval
,qml.var
,qml.probs
,qml.sample
,qml.counts
.Description of the Change:
qml.expval
,qml.probs
,qml.sample
,qml.var
,qml.counts
to handleMeasurmentValue
s.ExpectationMP
,VarianceMP
,SampleMP
,CountsMP
to handleMeasurementValue
s as observables for state and sample processing.measurements.rst
will be updated in a follow-up PR.Benefits:
Mid-circuit measurement statistics work.
Possible Drawbacks:
Related GitHub Issues: