Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove sampler_seed from spsa_grad #4550

Merged
merged 5 commits into from Aug 30, 2023
Merged

Remove sampler_seed from spsa_grad #4550

merged 5 commits into from Aug 30, 2023

Conversation

lillian542
Copy link
Contributor

Complete deprecation cycle for sampler_seed kwarg in spsa_grad

@github-actions
Copy link
Contributor

Hello. You may have forgotten to update the changelog!
Please edit doc/releases/changelog-dev.md with:

  • A one-to-two sentence description of the change. You may include a small working example for new features.
  • A link back to this PR.
  • Your name (or GitHub username) in the contributors section.

@lillian542
Copy link
Contributor Author

[sc-43901]

@codecov
Copy link

codecov bot commented Aug 29, 2023

Codecov Report

Patch coverage has no change and project coverage change: -0.01% ⚠️

Comparison is base (273ddc6) 99.66% compared to head (9001eab) 99.66%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #4550      +/-   ##
==========================================
- Coverage   99.66%   99.66%   -0.01%     
==========================================
  Files         376      376              
  Lines       33066    33059       -7     
==========================================
- Hits        32956    32949       -7     
  Misses        110      110              
Files Changed Coverage Δ
pennylane/gradients/spsa_gradient.py 100.00% <ø> (ø)

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@lillian542 lillian542 requested a review from a team August 29, 2023 21:28
doc/releases/changelog-dev.md Outdated Show resolved Hide resolved
Co-authored-by: Matthew Silverman <matthews@xanadu.ai>
@lillian542 lillian542 requested a review from a team August 30, 2023 13:45
@lillian542 lillian542 enabled auto-merge (squash) August 30, 2023 14:12
@lillian542 lillian542 merged commit 15bcf04 into master Aug 30, 2023
39 checks passed
@lillian542 lillian542 deleted the remove_sampler_seed branch August 30, 2023 14:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants