Fix copying the Select template #4551
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## master #4551 +/- ##
=======================================
Coverage 99.64% 99.64%
=======================================
Files 376 376
Lines 33249 33259 +10
=======================================
+ Hits 33130 33140 +10
Misses 119 119
☔ View full report in Codecov by Sentry. |
Jaybsoni
reviewed
Sep 7, 2023
Jaybsoni
reviewed
Sep 7, 2023
Jaybsoni
reviewed
Sep 7, 2023
Jaybsoni
approved these changes
Sep 7, 2023
Co-authored-by: Jay Soni <jbsoni@uwaterloo.ca>
mudit2812
pushed a commit
that referenced
this pull request
Sep 15, 2023
**Context:** `qml.Select` could not be copied with `copy.copy(qml.Select(...))`, resulting in errors with `qml.qsvt`. **Description of the Change:** Overrode the `__copy__` function in `qml.Select` **Benefits:** Allows `qml.Select` to be used with `qml.qsvt` more easily and allows it to be copied. **Possible Drawbacks:** Changes to `__copy__` in the base `Operator` class will no longer affect `qml.Select` --------- Co-authored-by: Jay Soni <jbsoni@uwaterloo.ca>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context:
qml.Selectcould not be copied withcopy.copy(qml.Select(...)), resulting in errors withqml.qsvt.Description of the Change:
Overrode the
__copy__function inqml.SelectBenefits:
Allows
qml.Selectto be used withqml.qsvtmore easily and allows it to be copied.Possible Drawbacks:
Changes to
__copy__in the baseOperatorclass will no longer affectqml.Select