-
Notifications
You must be signed in to change notification settings - Fork 578
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Validate wires on circuit before executing on new device; add repr to new device #4562
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me 🎉
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## master #4562 +/- ##
=======================================
Coverage 99.65% 99.65%
=======================================
Files 376 376
Lines 33103 33114 +11
=======================================
+ Hits 32990 33001 +11
Misses 113 113
☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some minor comments, but nothing blocking 👍
Co-authored-by: Christina Lee <christina@xanadu.ai>
Context:
There are some little things that would be nice to have on the new device. Here are 2 of them.
Description of the Change:
Benefits: