Update DecompositionUndefinedError for Exp class
#4571
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hello. You may have forgotten to update the changelog!
|
|
[sc-44544] |
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## master #4571 +/- ##
=======================================
Coverage 99.64% 99.64%
=======================================
Files 376 376
Lines 33071 33076 +5
=======================================
+ Hits 32955 32960 +5
Misses 116 116
☔ View full report in Codecov by Sentry. |
timmysilv
reviewed
Sep 6, 2023
timmysilv
approved these changes
Sep 7, 2023
mudit2812
pushed a commit
that referenced
this pull request
Sep 8, 2023
**Context:** When calling the decomposition for the `Exp` class with `num_steps` specified, an error was raised suggesting to set `num_steps`. The real source of the error was caused because the underlying operator was not unitary. The error message was misleading. **Description of the Change:** Update the decomposition function to perform added validation before raising error. **Benefits:** More informative error messages. **Possible Drawbacks:** None **Related GitHub Issues:** Fixes #4537
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context:
When calling the decomposition for the
Expclass withnum_stepsspecified, an error was raised suggesting to setnum_steps. The real source of the error was caused because the underlying operator was not unitary. The error message was misleading.Description of the Change:
Update the decomposition function to perform added validation before raising error.
Benefits:
More informative error messages.
Possible Drawbacks:
None
Related GitHub Issues:
Fixes #4537