Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Typo fix in qml.QuantumMonteCarlo documentation #4593

Merged
merged 6 commits into from Sep 28, 2023

Conversation

DanielNino27
Copy link
Contributor

Context:
User "Den" pointed out in the discussion forum that there is a 'dx' missing in the integral in the example usage of qml.QuantumMonteCarlo function.

Description of the Change:
Added a dx to the integral in the usage details, pointed out by Den in the Discussion Forum.

Benefits:
Fixes typo in documentation.
Possible Drawbacks:
None
Related GitHub Issues:
None

@github-actions
Copy link
Contributor

Hello. You may have forgotten to update the changelog!
Please edit doc/releases/changelog-dev.md with:

  • A one-to-two sentence description of the change. You may include a small working example for new features.
  • A link back to this PR.
  • Your name (or GitHub username) in the contributors section.

@codecov
Copy link

codecov bot commented Sep 13, 2023

Codecov Report

All modified lines are covered by tests ✅

Comparison is base (7406d68) 99.63% compared to head (6438b95) 99.63%.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #4593   +/-   ##
=======================================
  Coverage   99.63%   99.63%           
=======================================
  Files         376      376           
  Lines       33618    33618           
=======================================
  Hits        33494    33494           
  Misses        124      124           
Files Coverage Δ
pennylane/templates/subroutines/qmc.py 100.00% <ø> (ø)
pennylane/transforms/qmc.py 100.00% <ø> (ø)

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@DanielNino27 DanielNino27 changed the title [WIP] Typo fix in qml.QuantumMonteCarlo documentation Typo fix in qml.QuantumMonteCarlo documentation Sep 14, 2023
Copy link
Contributor

@DSGuala DSGuala left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Almost good to go! The example in the QuantumMonteCarlo template uses the same equation and also needs to be updated 🙏

Copy link
Contributor

@DSGuala DSGuala left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to go! Thanks @DanielNino27 !

@DanielNino27 DanielNino27 merged commit db5b792 into master Sep 28, 2023
39 checks passed
@DanielNino27 DanielNino27 deleted the daniel.nino-typofix-qmc-doc branch September 28, 2023 18:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants