Make the device API not-experimental #4594
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
timmysilv
commented
Sep 13, 2023
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## master #4594 +/- ##
==========================================
- Coverage 99.64% 99.64% -0.01%
==========================================
Files 376 375 -1
Lines 33340 33336 -4
==========================================
- Hits 33221 33217 -4
Misses 119 119
☔ View full report in Codecov by Sentry. |
trbromley
reviewed
Sep 14, 2023
mudit2812
approved these changes
Sep 14, 2023
Co-authored-by: Mudit Pandey <mudit.pandey@xanadu.ai>
lillian542
approved these changes
Sep 14, 2023
|
[sc-44916] |
# Conflicts: # pennylane/qinfo/transforms.py
mudit2812
added a commit
that referenced
this pull request
Sep 15, 2023
**Context:** DefaultQubit2 is the new DefaultQubit! Let us name it accordingly. **Description of the Change:** 1. Rename the existing `DefaultQubit` to `DefaultQubitLegacy` 2. Move the contents of `pennylane/devices/experimental` into `pennylane/devices` 3. Rename `DefaultQubit2` to `DefaultQubit` Notes/Follow-up: - The short names for DQL and DQ2 are still `default.qubit` and `default.qubit.2` respectively, and `default.qubit` still results in DQL. I will make that switch in another PR. - Some test files still need moving/renaming, but I'll do that in another PR. All files for DQ2 should be at the higher level, and all DQL files should be in a `legacy` folder with a `legacy` suffix, so that's next. To be extra clear about what's happened: - the old device API is still `qml.Device` - the new device API is now `qml.devices.Device` - If called directly, `qml.devices.DefaultQubit` return DQ2. `qml.devices.DefaultQubitLegacy` returns DQL **Benefits:** The Device API is no longer experimental! Will make the final switch much easier! **Possible Drawbacks:** I'm probably going to screw up merging this into mega-PR #4436 --------- Co-authored-by: Mudit Pandey <mudit.pandey@xanadu.ai>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context:
DefaultQubit2 is the new DefaultQubit! Let us name it accordingly.
Description of the Change:
DefaultQubittoDefaultQubitLegacypennylane/devices/experimentalintopennylane/devicesDefaultQubit2toDefaultQubitNotes/Follow-up:
default.qubitanddefault.qubit.2respectively, anddefault.qubitstill results in DQL. I will make that switch in another PR.legacyfolder with alegacysuffix, so that's next.To be extra clear about what's happened:
qml.Deviceqml.devices.Deviceqml.devices.DefaultQubitreturn DQ2.qml.devices.DefaultQubitLegacyreturns DQLBenefits:
The Device API is no longer experimental! Will make the final switch much easier!
Possible Drawbacks:
I'm probably going to screw up merging this into mega-PR #4436