Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BasisState accepts floats #4632

Merged
merged 4 commits into from Oct 2, 2023
Merged

BasisState accepts floats #4632

merged 4 commits into from Oct 2, 2023

Conversation

timmysilv
Copy link
Contributor

Context:
It's been failing all over since switching DQL with DQ2

Description of the Change:
Cast inputted values to float before making state vector

Benefits:
Float inputs are accepted and CI is fixed, parity with DQL

Possible Drawbacks:
N/A

Related GitHub Issues:
PennyLaneAI/pennylane-rigetti#142

@github-actions
Copy link
Contributor

Hello. You may have forgotten to update the changelog!
Please edit doc/releases/changelog-dev.md with:

  • A one-to-two sentence description of the change. You may include a small working example for new features.
  • A link back to this PR.
  • Your name (or GitHub username) in the contributors section.

@timmysilv timmysilv requested a review from a team September 26, 2023 15:50
@timmysilv timmysilv requested a review from a team September 28, 2023 14:02
@timmysilv timmysilv enabled auto-merge (squash) October 2, 2023 14:50
@codecov
Copy link

codecov bot commented Oct 2, 2023

Codecov Report

All modified lines are covered by tests ✅

Comparison is base (9a83734) 99.63% compared to head (7db3acf) 99.63%.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #4632   +/-   ##
=======================================
  Coverage   99.63%   99.63%           
=======================================
  Files         376      376           
  Lines       33616    33617    +1     
=======================================
+ Hits        33492    33493    +1     
  Misses        124      124           
Files Coverage Δ
pennylane/ops/qubit/state_preparation.py 100.00% <100.00%> (ø)

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@timmysilv timmysilv merged commit 4bae45d into master Oct 2, 2023
39 checks passed
@timmysilv timmysilv deleted the cast-to-int-basisstate branch October 2, 2023 15:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants