Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

pulse_generator becomes pulse_odegen #4633

Merged
merged 20 commits into from Sep 28, 2023
Merged

pulse_generator becomes pulse_odegen #4633

merged 20 commits into from Sep 28, 2023

Conversation

Qottmann
Copy link
Contributor

@Qottmann Qottmann commented Sep 27, 2023 •
edited

We renamed "the generator method" to "ODEgen" in its paper, and therefore change the naming in PennyLane to adhere to it.

TODO

  • update paper repository accordingly once PR is merged

@github-actions
Copy link
Contributor

Hello. You may have forgotten to update the changelog!
Please edit doc/releases/changelog-dev.md with:

  • A one-to-two sentence description of the change. You may include a small working example for new features.
  • A link back to this PR.
  • Your name (or GitHub username) in the contributors section.

lillian542
lillian542 approved these changes Sep 27, 2023
View reviewed changes
Copy link
Contributor

@lillian542 lillian542 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Couple of minor comments, looks good to me!

pennylane/gradients/pulse_gradient_odegen.py Outdated Show resolved Hide resolved
tests/gradients/core/test_pulse_gradient.py Outdated Show resolved Hide resolved
@Qottmann @lillian542
Update pennylane/gradients/pulse_gradient_odegen.py
9cae3fe 
Co-authored-by: lillian542 <38584660+lillian542@users.noreply.github.com>
dwierichs
dwierichs approved these changes Sep 27, 2023
View reviewed changes
Copy link
Contributor

@dwierichs dwierichs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, just caught a few tiny things, mostly in the tests.

Thanks @Qottmann :)

tests/gradients/core/test_pulse_odegen.py Outdated Show resolved Hide resolved
tests/gradients/core/test_pulse_odegen.py Outdated Show resolved Hide resolved
tests/gradients/core/test_pulse_odegen.py Outdated Show resolved Hide resolved
tests/gradients/core/test_pulse_odegen.py Outdated Show resolved Hide resolved
tests/gradients/core/test_pulse_odegen.py Outdated Show resolved Hide resolved
tests/gradients/core/test_pulse_odegen.py Outdated Show resolved Hide resolved
tests/gradients/core/test_pulse_gradient.py Outdated Show resolved Hide resolved
@Qottmann @dwierichs
Apply suggestions from code review
d224553 
Co-authored-by: David Wierichs <david.wierichs@xanadu.ai>
@codecov
Copy link

codecov bot commented Sep 27, 2023 •
edited

Codecov Report

All modified lines are covered by tests ✅

Comparison is base (d67be86) 99.63% compared to head (73665b0) 99.63%.
Report is 1 commits behind head on master.

Additional details and impacted files 
@@           Coverage Diff           @@
##           master    #4633   +/-   ##
=======================================
  Coverage   99.63%   99.63%           
=======================================
  Files         375      376    +1     
  Lines       33566    33618   +52     
=======================================
+ Hits        33442    33494   +52     
  Misses        124      124
Files Coverage Δ
pennylane/gradients/__init__.py 100.00% <100.00%> (ø)
pennylane/gradients/gradient_transform.py 100.00% <100.00%> (ø)
pennylane/gradients/jvp.py 100.00% <100.00%> (ø)
pennylane/gradients/pulse_gradient.py 99.47% <ø> (ø)
pennylane/gradients/pulse_gradient_odegen.py 100.00% <100.00%> (ø)
pennylane/interfaces/__init__.py 100.00% <ø> (ø)
pennylane/interfaces/jacobian_products.py 100.00% <100.00%> (ø)

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Qottmann Qottmann enabled auto-merge (squash) September 27, 2023 15:37
@Qottmann Qottmann enabled auto-merge (squash) September 28, 2023 09:45
@Qottmann Qottmann merged commit 7406d68 into master Sep 28, 2023
39 checks passed
@Qottmann Qottmann deleted the odegen branch September 28, 2023 10:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@trbromley trbromley trbromley left review comments

@dwierichs dwierichs dwierichs approved these changes

@lillian542 lillian542 lillian542 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@Qottmann @dwierichs @lillian542 @trbromley