Decomposition using GlobalPhase has real phase #4653
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hello. You may have forgotten to update the changelog!
|
lillian542
changed the title
|
[sc-44772] |
Codecov ReportAll modified lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #4653 +/- ##
=======================================
Coverage 99.65% 99.65%
=======================================
Files 376 376
Lines 33702 33702
=======================================
Hits 33585 33585
Misses 117 117
☔ View full report in Codecov by Sentry. |
lillian542
commented
Oct 6, 2023
lillian542
commented
Oct 6, 2023
lillian542
commented
Oct 6, 2023
|
Sorry if this is WIP, but please add to the changelog. |
|
This matches #4639 in that they're both attempting to identify real values with dtype=complex. Are they different problems? If everyone needs to set their own thresholds and their own decisions for when to cast, then nvm. But if not, I'd like to standardize how PennyLane deems "approximately real" values to be truly real, and casts them (likely in qml.math). Lmk thoughts. |
timmysilv
reviewed
Oct 10, 2023
1 task
|
Fixes #4565 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context:
When we added the
GlobalPhaseand updated the decompositions forQubitUnitaryto use it, we left the datatype for the phase as complex, even though the results are realDescription of the Change:
There is one line where the angles, though per definition real, need to have a complex dtype to avoid making PyTorch angry. They are now cast to real only there in that line, rather than carrying that through everywhere else.
Benefits:
Its cleaner