-
Notifications
You must be signed in to change notification settings - Fork 569
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Transform on devices and update insert #4667
Conversation
Hello. You may have forgotten to update the changelog!
|
Codecov ReportAll modified lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #4667 +/- ##
=======================================
Coverage 99.65% 99.65%
=======================================
Files 376 376
Lines 33678 33702 +24
=======================================
+ Hits 33561 33585 +24
Misses 117 117
☔ View full report in Codecov by Sentry. |
[sc-43680] |
tests/transforms/test_experimental/test_transform_dispatcher.py
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks like we've removed some test coverage from qfunc_transform
, but I'm fine with overriding that with in this case. qfunc_transform
is slated for deprecation, and its the fault of qfunc_transform
for not having proper unit tests.
Changelog and unit test for qml.Device
, and I'd be happy to approve :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
changes look good, just some little comments.
i don't remember if we had already changed some transforms in the last release, but will we need to announce the breaking changes re: how to decorate a qnode, particularly with @partial
?
@timmysilv I will update the transforms changelog during feature freeze to make sure all details are covered such as the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍 🚀
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'd like to allow for adding transforms to the front (rather than the back) of a program like this, but we can do that in another PR. For example, it would be useful if you want to decompose operators in a custom way before the device decomposition occurs (see what is being done in #4646 - it can't use this until support is added).
Description of the Change:
dev = transform(dev)
Benefits:
Possible Drawbacks:
Default mixed is not a new generation device, the main use cases of applying insert on a device is for default mixed (adding noise).
Related GitHub Issues: