Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix grover operator work wires #4668

Merged
merged 5 commits into from Oct 13, 2023
Merged

Fix grover operator work wires #4668

merged 5 commits into from Oct 13, 2023

Conversation

albi3ro
Copy link
Contributor

@albi3ro albi3ro commented Oct 12, 2023 •
edited

The default to GroverOperator for work wires was None. Unfortunately this was being interpreted as work_wires = Wires([None,]). This PR makes it so that work_wires=None is interpreted as work_wires = Wires([]).

Fixes PennyLaneAI/pennylane-qiskit#339

@albi3ro albi3ro requested review from a team and KetpuntoG October 12, 2023 13:38
@albi3ro
Copy link
Contributor Author

albi3ro commented Oct 12, 2023

[sc-47538]

@albi3ro albi3ro mentioned this pull request Oct 12, 2023
Closed
@codecov
Copy link

codecov bot commented Oct 12, 2023 •
edited

Codecov Report

All modified lines are covered by tests ✅

Comparison is base (7af90b4) 99.63% compared to head (96613a5) 99.65%.
Report is 1 commits behind head on master.

Additional details and impacted files 
@@            Coverage Diff             @@
##           master    #4668      +/-   ##
==========================================
+ Coverage   99.63%   99.65%   +0.02%     
==========================================
  Files         376      376              
  Lines       33678    33678              
==========================================
+ Hits        33554    33561       +7     
+ Misses        124      117       -7
Files Coverage Δ
pennylane/templates/subroutines/grover.py 100.00% <100.00%> (ø)

... and 3 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@albi3ro @timmysilv
Update pennylane/templates/subroutines/grover.py
e899832 
Co-authored-by: Matthew Silverman <matthews@xanadu.ai>
timmysilv
timmysilv approved these changes Oct 13, 2023
View reviewed changes
Copy link
Contributor

@timmysilv timmysilv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks!

@albi3ro albi3ro enabled auto-merge (squash) October 13, 2023 14:14
@albi3ro albi3ro merged commit eafabe4 into master Oct 13, 2023
39 checks passed
@albi3ro albi3ro deleted the fix-grover-work-wires branch October 13, 2023 15:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@timmysilv timmysilv timmysilv approved these changes

@lillian542 lillian542 lillian542 approved these changes

@KetpuntoG KetpuntoG Awaiting requested review from KetpuntoG

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

GroverOperator doesn't work properly in 'ibmq_qasm_simulator'
3 participants
@albi3ro @timmysilv @lillian542