[Compiler] Integrate with Catalyst Frontend #4692
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hello. You may have forgotten to update the changelog!
|
trbromley
reviewed
Oct 18, 2023
dime10
requested changes
Oct 18, 2023
There was a problem hiding this comment.
Thanks @maliasadi, I like this entry point design! I do have some concerns though:
josh146
reviewed
Oct 18, 2023
josh146
requested changes
Oct 18, 2023
There was a problem hiding this comment.
Nice work @maliasadi! I think I mostly have the same comments as @dime10, so once addressed this should be good to go 👍
rmoyard
reviewed
Oct 18, 2023
…e. Add the AvailableCompilers dataclass and update tests
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #4692 +/- ##
==========================================
- Coverage 99.65% 99.65% -0.01%
==========================================
Files 385 388 +3
Lines 34900 34700 -200
==========================================
- Hits 34780 34579 -201
- Misses 120 121 +1 ☔ View full report in Codecov by Sentry. |
maliasadi
force-pushed
the
maa/integrate-catalyst-2
branch
from
1932672
to
4fc9672
Compare
josh146
reviewed
Oct 20, 2023
josh146
reviewed
Oct 20, 2023
josh146
requested changes
Oct 20, 2023
There was a problem hiding this comment.
Really nice work @maliasadi -- the compiler module docstring is really well written and structured!
I managed to get mostly through the PR, but haven't had a chance to review qml.qjit yet, will do so tomorrow
grwlf
reviewed
Oct 20, 2023
josh146
reviewed
Oct 25, 2023
josh146
approved these changes
Oct 25, 2023
There was a problem hiding this comment.
Looks great from my end @maliasadi, excited to have this in 😍
Should we add a #do not merge label as a reminder not to merge this yet?
maliasadi
added
the
do not merge ⚠️
Co-authored-by: Josh Izaac <josh146@gmail.com>
|
⏰ This PR will be merged after the next release of Catalyst (v0.3.2) |
From the doc page of [pkg_resources](https://setuptools.pypa.io/en/latest/pkg_resources.html): > Use of pkg_resources is deprecated in favor of [importlib.resources](https://docs.python.org/3.11/library/importlib.resources.html#module-importlib.resources), [importlib.metadata](https://docs.python.org/3.11/library/importlib.metadata.html#module-importlib.metadata) and their backports ([importlib_resources](https://pypi.org/project/importlib_resources), [importlib_metadata](https://pypi.org/project/importlib_metadata)). Some useful APIs are also provided by [packaging](https://pypi.org/project/packaging) (e.g. requirements and version parsing). Users should refrain from new usage of pkg_resources and should work to port to importlib-based solutions. PR #4783 updates all occurrences of `pkg_resources` with `importlib.metadata` across the entire PL. This PR, however, addresses this replacement in the compiler driver, which has not yet been merged into PL. [sc-46399]
Context: This PR adds support for QJIT compatible `qml.jacobian` and `qml.grad`. Please see ADR 74 for implementation details. [sc-46406] --------- Co-authored-by: Josh Izaac <josh146@gmail.com>
timmysilv
reviewed
Nov 8, 2023
timmysilv
approved these changes
Nov 10, 2023
This was referenced Nov 14, 2023
…#4812) This PR updates the support and addresses code review suggestions in PR #4692. - [x] Activate integration tests in CI (using Catalyst v0.3.2) - [x] Fix docstring issues in the compiler and grad docs - [x] Use `h` instead of `step_size` in grad ops - [x] Update code coverage of the compiler module
maliasadi
removed
the
do not merge ⚠️
trbromley
reviewed
Nov 28, 2023
josh146
reviewed
Nov 28, 2023
josh146
reviewed
Nov 28, 2023
josh146
reviewed
Nov 28, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context:
We implement a
compilermodule that provides the PennyLane's native JIT compilation support.This
compilersubpackage exclusively functions as a wrapper for PennyLane's JIT compiler packages, without independently implementing any compiler itself. Currently, it supports the 'pennylane-catalyst' package, with plans to incorporate additional packages in the near future.For any compiler packages seeking to be registered, it is imperative that they expose the 'entry_points' metadata under the designated group name:
pennylane.compilers. (Check PR PennyLaneAI/catalyst#321 for details)Description of the Change:
qml.compiler: The JIT compiler module containing all utilities and wrapper methods forqml.qjitin PennyLane.qml.qjit: A just-in-time decorator for PennyLane and JAX programs backed by CatalystBenefits: Compiling hybrid programs without explicitly importing Catalyst.
Possible Drawbacks: To use
qml.qjit, users need to manually installpennylane-catalyst.[sc-46400]
[sc-46401]