-
Notifications
You must be signed in to change notification settings - Fork 568
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix LocalHilbertSchmidt
template
#4719
Conversation
Hello. You may have forgotten to update the changelog!
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## v0.33.0-rc0 #4719 +/- ##
==============================================
Coverage ? 99.64%
==============================================
Files ? 380
Lines ? 33985
Branches ? 0
==============================================
Hits ? 33863
Misses ? 122
Partials ? 0 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you, good catch 👍
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm! will make sure my branch is correctly updated
[sc-48521]
When run with a
QNode
, theLocalHilbertSchmidt
template raises:The decomposition uses
qml.apply
without checking that something is recording. This failure was not found because there were no integration tests checking that the template worked in aQNode
.