Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix LocalHilbertSchmidt template #4719

Merged
merged 3 commits into from
Oct 24, 2023
Merged

Fix LocalHilbertSchmidt template #4719

merged 3 commits into from
Oct 24, 2023

Conversation

albi3ro
Copy link
Contributor

@albi3ro albi3ro commented Oct 24, 2023

[sc-48521]

When run with a QNode, the LocalHilbertSchmidt template raises:

RuntimeError: No queuing context available to append operation to.

The decomposition uses qml.apply without checking that something is recording. This failure was not found because there were no integration tests checking that the template worked in a QNode.

@github-actions
Copy link
Contributor

Hello. You may have forgotten to update the changelog!
Please edit doc/releases/changelog-dev.md with:

  • A one-to-two sentence description of the change. You may include a small working example for new features.
  • A link back to this PR.
  • Your name (or GitHub username) in the contributors section.

@albi3ro albi3ro changed the base branch from master to v0.33.0-rc0 October 24, 2023 16:32
@albi3ro albi3ro added the bug 🐛 Something isn't working label Oct 24, 2023
@codecov
Copy link

codecov bot commented Oct 24, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

❗ No coverage uploaded for pull request base (v0.33.0-rc0@02659eb). Click here to learn what that means.

Additional details and impacted files
@@              Coverage Diff               @@
##             v0.33.0-rc0    #4719   +/-   ##
==============================================
  Coverage               ?   99.64%           
==============================================
  Files                  ?      380           
  Lines                  ?    33985           
  Branches               ?        0           
==============================================
  Hits                   ?    33863           
  Misses                 ?      122           
  Partials               ?        0           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mudit2812 mudit2812 added this to the v0.33 milestone Oct 24, 2023
Copy link
Contributor

@rmoyard rmoyard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, good catch 👍

Copy link
Contributor

@timmysilv timmysilv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm! will make sure my branch is correctly updated

@albi3ro albi3ro merged commit afa3e40 into v0.33.0-rc0 Oct 24, 2023
32 checks passed
@albi3ro albi3ro deleted the hilbert-schmidt-fix branch October 24, 2023 18:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug 🐛 Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants