Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove the prep keyword argument from tape #4756

Merged
merged 6 commits into from Oct 31, 2023
Merged

Conversation

timmysilv
Copy link
Contributor

Context:
The prep kwarg from tape is no longer needed, and is being removed.

Description of the Change:
Remove the prep kwarg from tape

Benefits:
less code!

Possible Drawbacks:
N/A

[sc-47809]

doc/development/deprecations.rst Outdated Show resolved Hide resolved
doc/releases/changelog-dev.md Outdated Show resolved Hide resolved
@timmysilv timmysilv requested a review from a team October 30, 2023 18:45
@codecov
Copy link

codecov bot commented Oct 30, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (099bc38) 99.64% compared to head (2e7f11b) 99.64%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #4756      +/-   ##
==========================================
- Coverage   99.64%   99.64%   -0.01%     
==========================================
  Files         381      381              
  Lines       34316    34052     -264     
==========================================
- Hits        34195    33930     -265     
- Misses        121      122       +1     
Files Coverage Δ
pennylane/tape/operation_recorder.py 96.77% <100.00%> (ø)
pennylane/tape/qscript.py 100.00% <ø> (ø)
pennylane/tape/tape.py 98.54% <100.00%> (-0.02%) ⬇️

... and 40 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mudit2812
Copy link
Contributor

Minor change, but breaking regardless, so let's hold off on merging it until after the release stuff is done. I don't want to end up in another situation like last time when we removed qml.active_return and it broke two plugins and caused the qml builds to fail.

Copy link
Contributor

@mudit2812 mudit2812 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Otherwise looks good!

# Conflicts:
#	doc/releases/changelog-dev.md
@timmysilv timmysilv enabled auto-merge (squash) October 31, 2023 14:51
@timmysilv timmysilv merged commit b553a37 into master Oct 31, 2023
33 checks passed
@timmysilv timmysilv deleted the remove-prep-tape branch October 31, 2023 17:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants