New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
remove the prep keyword argument from tape #4756
Conversation
# Conflicts: # doc/development/deprecations.rst
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #4756 +/- ##
==========================================
- Coverage 99.64% 99.64% -0.01%
==========================================
Files 381 381
Lines 34316 34052 -264
==========================================
- Hits 34195 33930 -265
- Misses 121 122 +1
☔ View full report in Codecov by Sentry. |
Minor change, but breaking regardless, so let's hold off on merging it until after the release stuff is done. I don't want to end up in another situation like last time when we removed |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Otherwise looks good!
# Conflicts: # doc/releases/changelog-dev.md
Context:
The
prep
kwarg from tape is no longer needed, and is being removed.Description of the Change:
Remove the
prep
kwarg from tapeBenefits:
less code!
Possible Drawbacks:
N/A
[sc-47809]