add a setter to avoid breaking Observable.return_type #4798
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
albi3ro
reviewed
Nov 7, 2023
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #4798 +/- ##
==========================================
- Coverage 99.64% 99.63% -0.01%
==========================================
Files 381 381
Lines 34324 34068 -256
==========================================
- Hits 34202 33945 -257
- Misses 122 123 +1
☔ View full report in Codecov by Sentry. |
albi3ro
approved these changes
Nov 7, 2023
timmysilv
commented
Nov 7, 2023
lillian542
approved these changes
Nov 7, 2023
|
[sc-45858] |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context:
Some plugin tests failed because they were setting this property, which I did not expect.
Description of the Change:
Add a setter to the
Observable.return_typeproperty to avoid breaking things in this release. Also warn if someone uses it.Benefits:
We don't break
Observable.return_typein this release.Possible Drawbacks:
People can still set it? idk seems like a safe call for now. I'm not validating the type provided
Related GitHub Issues:
missed in #4762