New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Clifford+T Decomposition Transform #4802

Merged

obliviateandsurrender merged 78 commits into master from clifford_t_decomposition_transform

Dec 7, 2023

Contributor

obliviateandsurrender commented Nov 7, 2023

Context: Transform to perform Clifford+T decomposition

Description of the Change: Unrolls the circuit into Clifford+Rotation basis and then uses the Solovay-Kitaev algorithm for approximating arbitrary z-rotations.

Benefits: Allows one to transform any random circuit to a Clifford+Phase basis.

Possible Drawbacks: Might be sub-optimal

Related GitHub Issues:

obliviateandsurrender added 6 commits

November 7, 2023 15:25


          solovay-kitaev commit

23356af


          transform init

7493a37


          change basis

faddb17


          add changelog

aadc4d5


          update sk

824e371


          fix tests

7246aa8

Contributor

github-actions bot commented Nov 7, 2023

Hello. You may have forgotten to update the changelog!
Please edit doc/releases/changelog-dev.md with:

A one-to-two sentence description of the change. You may include a small working example for new features.
A link back to this PR.
Your name (or GitHub username) in the contributors section.

obliviateandsurrender added 2 commits

November 7, 2023 17:49


          add changelog

bd29e1e


          happy black

e879d99

codecov bot commented Nov 7, 2023 •

edited

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (49b0b71) 99.66% compared to head (62599db) 99.66%.

Additional details and impacted files

@@            Coverage Diff             @@
##           master    #4802      +/-   ##
==========================================
- Coverage   99.66%   99.66%   -0.01%     
==========================================
  Files         387      388       +1     
  Lines       35078    35019      -59     
==========================================
- Hits        34961    34901      -60     
- Misses        117      118       +1

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

obliviateandsurrender added 2 commits

November 7, 2023 19:00


          fix docs

1918c9b


          fix imorts

bf5d794

obliviateandsurrender requested a review from timmysilv

November 8, 2023 00:28

obliviateandsurrender added 2 commits

November 7, 2023 19:39


          faster tests

8928e34


          Merge branch 'master' into clifford_t_decomposition_transform

259d402

trbromley reviewed

View reviewed changes

doc/releases/changelog-dev.md Outdated Show resolved Hide resolved

pennylane/transforms/decompositions/clifford_t/clifford_t_transform.py Outdated Show resolved Hide resolved

timmysilv and others added 9 commits

November 14, 2023 13:29


          take PR suggestions

abda268

Co-authored-by: Tom Bromley <49409390+trbromley@users.noreply.github.com>
Co-authored-by: soranjh <40344468+soranjh@users.noreply.github.com>


          start with basis_gates instead of identity

6e67fb0


          Merge branch 'master' into solovay_kitaev_decompose

fa92622


          address PR comments

8db730b


          keep the assertion simple

83b444e


          Merge branch 'master' into solovay_kitaev_decompose

3a86322


          Merge branch 'master' into solovay_kitaev_decompose

829ee09


          Merge branch 'master' into solovay_kitaev_decompose

50f0003


          Merge branch 'solovay_kitaev_decompose' into clifford_t_decomposition…

a405c9f

…_transform

# Conflicts:
#	doc/releases/changelog-dev.md
#	pennylane/transforms/__init__.py
#	pennylane/transforms/decompositions/__init__.py
#	pennylane/transforms/decompositions/clifford_t/__init__.py
#	pennylane/transforms/decompositions/clifford_t/solovay_kitaev.py
#	tests/transforms/test_clifford_t/test_solovay_kitaev.py

timmysilv changed the base branch from master to solovay_kitaev_decompose

November 20, 2023 15:28

Contributor

timmysilv commented Nov 20, 2023

ps: just merge the SK branch into this one, and changed this one's base to the SK branch. just so I can work on this before merging SK without worry.

timmysilv added 3 commits

November 20, 2023 14:27


          tidying and little improvements

7dc9631


          reformat to avoid unnecessary work and please codecov; filter warnings

b940d26


          re-write SK recursion to allow for iterative error-checking

850e050


          minor tweaks

0557c8f

obliviateandsurrender requested a review from trbromley

November 28, 2023 22:04

obliviateandsurrender added 3 commits

November 28, 2023 19:55


          generalize check_clifford

ed5f8eb


          tweak docs

23e87b2


          happy pylint

e26fd1b

soranjh reviewed

View reviewed changes

pennylane/transforms/decompositions/clifford_t/clifford_t_transform.py Show resolved Hide resolved

pennylane/transforms/decompositions/clifford_t/clifford_t_transform.py Outdated Show resolved Hide resolved

pennylane/transforms/decompositions/clifford_t/clifford_t_transform.py Outdated Show resolved Hide resolved

pennylane/transforms/decompositions/clifford_t/clifford_t_transform.py Outdated Show resolved Hide resolved

pennylane/transforms/decompositions/clifford_t/clifford_t_transform.py Outdated Show resolved Hide resolved

pennylane/transforms/decompositions/clifford_t/clifford_t_transform.py Show resolved Hide resolved

pennylane/transforms/decompositions/clifford_t/clifford_t_transform.py Show resolved Hide resolved

pennylane/transforms/decompositions/clifford_t/clifford_t_transform.py Show resolved Hide resolved

pennylane/transforms/decompositions/clifford_t/clifford_t_transform.py Outdated Show resolved Hide resolved


          tweak docs

fca780f

obliviateandsurrender requested a review from soranjh

November 30, 2023 03:57

obliviateandsurrender added 2 commits

December 1, 2023 11:34


          refine docs

06e01d9


          Merge branch 'master' into clifford_t_decomposition_transform

1a85659

trbromley reviewed

View reviewed changes

Contributor

trbromley left a comment

Thanks @obliviateandsurrender @timmysilv! No major bottlenecks from my side. My main concern now is performance, it's a little slow for very small circuits and takes a very long time for more complex things like StronglyEntanglingLayers. Have we run a quick benchmark to see what's the most time consuming part?

pennylane/transforms/decompositions/clifford_t/solovay_kitaev.py Show resolved Hide resolved

pennylane/transforms/decompositions/clifford_t/clifford_t_transform.py Show resolved Hide resolved

pennylane/transforms/__init__.py Outdated Show resolved Hide resolved

pennylane/transforms/optimization/merge_rotations.py Show resolved Hide resolved


          modify docstring

0e2d54c

obliviateandsurrender requested a review from trbromley

December 5, 2023 22:17

obliviateandsurrender commented

View reviewed changes

Contributor Author

obliviateandsurrender left a comment

Looking at the benchmarks, I think little can be done quickly about the performance in this PR. It would require some extra effort that we can aim for in a future PR.

obliviateandsurrender added 2 commits

December 6, 2023 07:51


          Merge branch 'master' into clifford_t_decomposition_transform

d840720


          add check for non-zero global phase

b89838f

timmysilv reviewed

View reviewed changes

pennylane/transforms/decompositions/clifford_t/clifford_t_transform.py Outdated Show resolved Hide resolved

obliviateandsurrender added 3 commits

December 7, 2023 14:40


          tweak non-zero condition

dc873a1


          Merge branch 'master' into clifford_t_decomposition_transform

a6cb76b


          Trigger rebuild

108a9a6

trbromley approved these changes

View reviewed changes

Contributor

trbromley left a comment

Thanks @obliviateandsurrender @timmysilv! It's great to have this capability available 🎉 🎊

Next step is to make this decomposition, and specs, more performant, as these are useful in resource estimation.

pennylane/transforms/decompositions/clifford_t/clifford_t_transform.py Outdated Show resolved Hide resolved

pennylane/transforms/decompositions/clifford_t/clifford_t_transform.py Outdated Show resolved Hide resolved

pennylane/transforms/decompositions/clifford_t/clifford_t_transform.py Outdated Show resolved Hide resolved

pennylane/transforms/decompositions/clifford_t/clifford_t_transform.py Show resolved Hide resolved


          tweak docs

e63ba6a

trbromley reviewed

View reviewed changes

pennylane/transforms/__init__.py Show resolved Hide resolved

trbromley mentioned this pull request

Release notes updates #4918

Merged


          Merge branch 'master' into clifford_t_decomposition_transform

62599db

obliviateandsurrender enabled auto-merge (squash)

December 7, 2023 22:21

obliviateandsurrender merged commit dcd1201 into master

35 checks passed

obliviateandsurrender deleted the clifford_t_decomposition_transform branch

December 7, 2023 22:42

trbromley mentioned this pull request

Decompose gates into universal set (Clifford + T) #3162

Closed

mudit2812 pushed a commit that referenced this pull request


          Clifford+T Decomposition Transform (#4802)

b4e65da

Context: Transform to perform Clifford+T decomposition

Description of the Change: Unrolls the circuit into Clifford+Rotation
basis and then uses the Solovay-Kitaev algorithm for approximating
arbitrary z-rotations.

Benefits: Allows one to transform any random circuit to a Clifford+Phase
basis.

Possible Drawbacks: Might be sub-optimal

Related GitHub Issues:

---------

Co-authored-by: Matthew Silverman <matthews@xanadu.ai>
Co-authored-by: Tom Bromley <49409390+trbromley@users.noreply.github.com>
Co-authored-by: soranjh <40344468+soranjh@users.noreply.github.com>

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment