Adding functionality `iterative_qpe` #4804

KetpuntoG · 2023-11-07T23:56:19Z

Adding functionality iterative_qpe

github-actions · 2023-11-07T23:56:39Z

Hello. You may have forgotten to update the changelog!
Please edit doc/releases/changelog-dev.md with:

A one-to-two sentence description of the change. You may include a small working example for new features.
A link back to this PR.
Your name (or GitHub username) in the contributors section.

codecov · 2023-11-08T00:14:19Z

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (1f47116) 99.65% compared to head (5f63e0f) 99.64%.
Report is 1 commits behind head on master.

Additional details and impacted files

@@            Coverage Diff             @@
##           master    #4804      +/-   ##
==========================================
- Coverage   99.65%   99.64%   -0.01%     
==========================================
  Files         382      383       +1     
  Lines       34500    34253     -247     
==========================================
- Hits        34380    34132     -248     
- Misses        120      121       +1

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Jaybsoni

Amazing work! Looks pretty much good to go. I left some stylistic comments. The only other thing I can think to add if we have time would be one integration test which tests a full workflow like: given a hamiltonian compute its ground state energy using IQPE.

Other than that, once the comments are addressed I am happy to approve 💯

doc/releases/changelog-dev.md

pennylane/ops/functions/__init__.py

pennylane/ops/functions/iterative_qpe.py

tests/ops/functions/test_iterative_qpe.py

pennylane/ops/functions/iterative_qpe.py

Co-authored-by: Jay Soni <jbsoni@uwaterloo.ca>

mudit2812

Thanks Guillermo! Such an exciting feature 😄 . Just one comment about testing gradients with other interfaces, but otherwise looks good. Once addressed, I'm ready to approve 🚀

pennylane/ops/functions/iterative_qpe.py

tests/ops/functions/test_iterative_qpe.py

pennylane/ops/functions/iterative_qpe.py

Co-authored-by: Mudit Pandey <mudit.pandey@xanadu.ai>

…IQPE

KetpuntoG · 2023-11-10T19:23:39Z

I've added test for tensorflow and torch.
It has been identified a bug, so the tests will not pass until it is solved:
This is the issue:

#4825

pennylane/ops/functions/iterative_qpe.py

Co-authored-by: Tom Bromley <49409390+trbromley@users.noreply.github.com>

Jaybsoni · 2023-11-15T15:41:37Z

[sc-45848]

doc/introduction/operations.rst

Jaybsoni

Just some stylistic comments, otherwise I think this is good to go! I am approving for now, feel free to merge once the comments are resolved!

doc/releases/changelog-dev.md

pennylane/ops/functions/iterative_qpe.py

tests/ops/functions/test_iterative_qpe.py

doc/releases/changelog-dev.md

pennylane/ops/functions/iterative_qpe.py

Co-authored-by: soranjh <40344468+soranjh@users.noreply.github.com>

mudit2812

Looks good, just one question but otherwise I'm ready to approve :)

tests/ops/functions/test_iterative_qpe.py

mudit2812

Thanks!

trbromley · 2023-11-22T18:58:06Z

pennylane/ops/functions/iterative_qpe.py

+        >>> print(qml.draw(circuit)())
+
+        1: ──H─╭●────────────H──┤↗│  │0⟩──H─╭●────────────Rϕ(-1.57)──H──┤↗│  │0⟩──H─╭●────────────Rϕ(-1.57)──Rϕ(-0.79)──H──┤↗│  │0⟩─┤  Sample  Sample  Sample
+        0: ──X─╰RZ(2.00)⁴⋅⁰──────║──────────╰RZ(2.00)²⋅⁰──║──────────────║──────────╰RZ(2.00)¹⋅⁰──║──────────║──────────────────────┤


@KetpuntoG

RZ(2.00)⁴⋅⁰

Is this 4.0 because the power is a float?

good catch! This was something we modified at the end to work with torch instead of tensorflow.
It is an integer. It is updated in this PR

https://github.com/PennyLaneAI/pennylane/pull/4871/files

Iterative qpe

c36d09a

KetpuntoG added 2 commits November 7, 2023 19:23

black

fbd0558

change log

0ff9830

Jaybsoni reviewed Nov 8, 2023

View reviewed changes

Jaybsoni and others added 6 commits November 8, 2023 12:29

Merge branch 'master' into IQPE

7136b18

Update doc/releases/changelog-dev.md

926faf5

Co-authored-by: Jay Soni <jbsoni@uwaterloo.ca>

Update pennylane/ops/functions/iterative_qpe.py

db53884

Co-authored-by: Jay Soni <jbsoni@uwaterloo.ca>

Update tests/ops/functions/test_iterative_qpe.py

2d49959

Co-authored-by: Jay Soni <jbsoni@uwaterloo.ca>

Update pennylane/ops/functions/iterative_qpe.py

fb62e5e

Co-authored-by: Jay Soni <jbsoni@uwaterloo.ca>

extra test + Jay comments

b853231

mudit2812 reviewed Nov 10, 2023

View reviewed changes

pennylane/ops/functions/iterative_qpe.py Show resolved Hide resolved

tests/ops/functions/test_iterative_qpe.py Show resolved Hide resolved

mudit2812 reviewed Nov 10, 2023

View reviewed changes

pennylane/ops/functions/iterative_qpe.py Outdated Show resolved Hide resolved

KetpuntoG and others added 6 commits November 10, 2023 11:18

Update pennylane/ops/functions/iterative_qpe.py

f15f4fb

Co-authored-by: Mudit Pandey <mudit.pandey@xanadu.ai>

other diff methods

4a48997

Merge branch 'IQPE' of https://github.com/PennyLaneAI/pennylane into …

8730901

…IQPE

Update iterative_qpe.py

f183646

fixing test tensorflow

ca6ea55

Update test_iterative_qpe.py

12f0217

KetpuntoG added 7 commits November 14, 2023 10:18

xfail

6210335

Merge branch 'master' into IQPE

9f22a29

adding print

6eb7642

black

d2cbcf9

trying to fix shpinx

78f4a13

Update test_iterative_qpe.py

7ded8e2

Update iterative_qpe.py

f947d07

trbromley reviewed Nov 15, 2023

View reviewed changes

pennylane/ops/functions/iterative_qpe.py Outdated Show resolved Hide resolved

Update pennylane/ops/functions/iterative_qpe.py

c2b5a4e

Co-authored-by: Tom Bromley <49409390+trbromley@users.noreply.github.com>

Merge branch 'master' into IQPE

c902fdb

Jaybsoni reviewed Nov 15, 2023

View reviewed changes

doc/introduction/operations.rst Show resolved Hide resolved

Jaybsoni approved these changes Nov 15, 2023

View reviewed changes

KetpuntoG added 2 commits November 15, 2023 11:48

estimation_wire -> ancilla

a03ae76

Merge branch 'master' into IQPE

578d484

KetpuntoG commented Nov 15, 2023

View reviewed changes

doc/releases/changelog-dev.md Outdated Show resolved Hide resolved

Update doc/releases/changelog-dev.md

e3179af

soranjh reviewed Nov 20, 2023

View reviewed changes

pennylane/ops/functions/iterative_qpe.py Outdated Show resolved Hide resolved

pennylane/ops/functions/iterative_qpe.py Outdated Show resolved Hide resolved

pennylane/ops/functions/iterative_qpe.py Outdated Show resolved Hide resolved

KetpuntoG and others added 4 commits November 20, 2023 12:51

Update pennylane/ops/functions/iterative_qpe.py

6dddd1e

Co-authored-by: soranjh <40344468+soranjh@users.noreply.github.com>

Update pennylane/ops/functions/iterative_qpe.py

3d6c578

Co-authored-by: soranjh <40344468+soranjh@users.noreply.github.com>

Update pennylane/ops/functions/iterative_qpe.py

b179746

Co-authored-by: soranjh <40344468+soranjh@users.noreply.github.com>

Merge branch 'master' into IQPE

5f63e0f

mudit2812 reviewed Nov 21, 2023

View reviewed changes

tests/ops/functions/test_iterative_qpe.py Show resolved Hide resolved

mudit2812 approved these changes Nov 21, 2023

View reviewed changes

KetpuntoG merged commit bea3682 into master Nov 21, 2023
33 checks passed

KetpuntoG deleted the IQPE branch November 21, 2023 19:15

trbromley reviewed Nov 22, 2023

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Adding functionality `iterative_qpe` #4804

Adding functionality `iterative_qpe` #4804

KetpuntoG commented Nov 7, 2023

github-actions bot commented Nov 7, 2023

codecov bot commented Nov 8, 2023 •

edited

Jaybsoni left a comment

mudit2812 left a comment

KetpuntoG commented Nov 10, 2023

Jaybsoni commented Nov 15, 2023

Jaybsoni left a comment

mudit2812 left a comment

mudit2812 left a comment

trbromley Nov 22, 2023

KetpuntoG Nov 22, 2023

Adding functionality iterative_qpe #4804

Adding functionality iterative_qpe #4804

Conversation

KetpuntoG commented Nov 7, 2023

github-actions bot commented Nov 7, 2023

codecov bot commented Nov 8, 2023 • edited

Codecov Report

Jaybsoni left a comment

Choose a reason for hiding this comment

mudit2812 left a comment

Choose a reason for hiding this comment

KetpuntoG commented Nov 10, 2023

Jaybsoni commented Nov 15, 2023

Jaybsoni left a comment

Choose a reason for hiding this comment

mudit2812 left a comment

Choose a reason for hiding this comment

mudit2812 left a comment

Choose a reason for hiding this comment

trbromley Nov 22, 2023

Choose a reason for hiding this comment

KetpuntoG Nov 22, 2023

Choose a reason for hiding this comment

Adding functionality `iterative_qpe` #4804

Adding functionality `iterative_qpe` #4804

codecov bot commented Nov 8, 2023 •

edited