New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added parity transformation for issue #4881 #4928
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #4928 +/- ##
==========================================
- Coverage 99.69% 99.68% -0.01%
==========================================
Files 393 393
Lines 35864 35641 -223
==========================================
- Hits 35753 35529 -224
- Misses 111 112 +1 ☔ View full report in Codecov by Sentry. |
Co-authored-by: Jay Soni <jbsoni@uwaterloo.ca>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall great work @ddhawan11! This feature looks good and seems to be working as expected! Just a few small questions and clarifications to address and I will be happy to approve! 💯
Feel free to request a re-review when you are ready, otherwise I am happy to answer any questions or concerns you have in the comment threads below.
Thanks,
Co-authored-by: Jay Soni <jbsoni@uwaterloo.ca>
Co-authored-by: soranjh <40344468+soranjh@users.noreply.github.com>
Co-authored-by: soranjh <40344468+soranjh@users.noreply.github.com>
Co-authored-by: soranjh <40344468+soranjh@users.noreply.github.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @ddhawan11, looks good to go. Just make sure to sync with master properly.
Co-authored-by: soranjh <40344468+soranjh@users.noreply.github.com>
Co-authored-by: soranjh <40344468+soranjh@users.noreply.github.com>
Co-authored-by: soranjh <40344468+soranjh@users.noreply.github.com>
Thanks @ddhawan11 for contributing! This PR should make it out as part of our 0.35 release on March 5th. We often tag contributors in our release marketing on Twitter/X. If you would optionally like to be tagged, please could you share your username? |
My twitter/X username is @ddhawan_21. |
Before submitting
Please complete the following checklist when submitting a PR:
When all the above are checked, delete everything above the dashed
line and fill in the pull request template.
Context:
Parity transform is added to map fermionic operators to qubit operators.
Description of the Change:
Benefits:
Possible Drawbacks:
Related GitHub Issues: