Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added parity transformation for issue #4881 #4928

Merged
merged 93 commits into from Jan 31, 2024

Conversation

ddhawan11
Copy link
Contributor

@ddhawan11 ddhawan11 commented Dec 7, 2023

Before submitting

Please complete the following checklist when submitting a PR:

When all the above are checked, delete everything above the dashed
line and fill in the pull request template.


Context:
Parity transform is added to map fermionic operators to qubit operators.

Description of the Change:

Benefits:

Possible Drawbacks:

Related GitHub Issues:

@ddhawan11 ddhawan11 closed this Dec 8, 2023
@ddhawan11 ddhawan11 reopened this Dec 8, 2023
@ddhawan11 ddhawan11 closed this Dec 8, 2023
@ddhawan11 ddhawan11 reopened this Dec 8, 2023
@ddhawan11 ddhawan11 closed this Dec 8, 2023
@ddhawan11 ddhawan11 reopened this Dec 8, 2023
@ddhawan11 ddhawan11 closed this Dec 8, 2023
@ddhawan11 ddhawan11 reopened this Dec 8, 2023
Copy link

codecov bot commented Dec 8, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (cfe2991) 99.69% compared to head (2b971e0) 99.68%.
Report is 2 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #4928      +/-   ##
==========================================
- Coverage   99.69%   99.68%   -0.01%     
==========================================
  Files         393      393              
  Lines       35864    35641     -223     
==========================================
- Hits        35753    35529     -224     
- Misses        111      112       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Co-authored-by: Jay Soni <jbsoni@uwaterloo.ca>
Copy link
Contributor

@Jaybsoni Jaybsoni left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall great work @ddhawan11! This feature looks good and seems to be working as expected! Just a few small questions and clarifications to address and I will be happy to approve! 💯

Feel free to request a re-review when you are ready, otherwise I am happy to answer any questions or concerns you have in the comment threads below.

Thanks,

pennylane/fermi/conversion.py Outdated Show resolved Hide resolved
pennylane/fermi/conversion.py Outdated Show resolved Hide resolved
pennylane/fermi/conversion.py Show resolved Hide resolved
pennylane/fermi/conversion.py Outdated Show resolved Hide resolved
pennylane/fermi/conversion.py Outdated Show resolved Hide resolved
pennylane/fermi/conversion.py Outdated Show resolved Hide resolved
pennylane/fermi/conversion.py Outdated Show resolved Hide resolved
tests/fermi/test_parity_mapping.py Outdated Show resolved Hide resolved
tests/fermi/test_parity_mapping.py Outdated Show resolved Hide resolved
tests/fermi/test_parity_mapping.py Outdated Show resolved Hide resolved
pennylane/fermi/conversion.py Outdated Show resolved Hide resolved
pennylane/fermi/conversion.py Outdated Show resolved Hide resolved
pennylane/fermi/conversion.py Outdated Show resolved Hide resolved
Copy link
Contributor

@soranjh soranjh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @ddhawan11, looks good to go. Just make sure to sync with master properly.

ddhawan11 and others added 4 commits January 30, 2024 12:09
Co-authored-by: soranjh <40344468+soranjh@users.noreply.github.com>
Co-authored-by: soranjh <40344468+soranjh@users.noreply.github.com>
Co-authored-by: soranjh <40344468+soranjh@users.noreply.github.com>
@soranjh soranjh merged commit c2afd15 into PennyLaneAI:master Jan 31, 2024
35 checks passed
@trbromley
Copy link
Contributor

Thanks @ddhawan11 for contributing! This PR should make it out as part of our 0.35 release on March 5th.

We often tag contributors in our release marketing on Twitter/X. If you would optionally like to be tagged, please could you share your username?

@ddhawan11
Copy link
Contributor Author

My twitter/X username is @ddhawan_21.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants