Correctly compare Controlled operators with differing control wire order #4944
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1 task
|
Hello. You may have forgotten to update the changelog!
|
|
[sc-50266] |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #4944 +/- ##
==========================================
- Coverage 99.66% 99.66% -0.01%
==========================================
Files 388 388
Lines 35379 35111 -268
==========================================
- Hits 35262 34993 -269
- Misses 117 118 +1 ☔ View full report in Codecov by Sentry. |
albi3ro
approved these changes
Dec 12, 2023
…ylane into controlled_equal_update
mudit2812
pushed a commit
that referenced
this pull request
Dec 15, 2023
…der (#4944) **Context:** As long as the mapping of control wires to control values is the same, the order of control wires doesn't matter when comparing two Controlled operators, but the current implementation of `qml.equal` doesn't consider this. This currently returns False, because the wires differ in order: ``` base1 = qml.PauliX(wires=0) base2 = qml.PauliX(wires=0) op1 = qml.ops.op_math.Controlled(base1, control_wires=[1, 2]) op2 = qml.ops.op_math.Controlled(base2, control_wires=[2, 1]) print(qml.equal(op1, op2)) ``` **Description of the Change:** Instead of comparing the operator wires and the control values, we compare the `work_wires` of the two operators, and we compare dictionaries of `{wire1: value1, wire2: value2...}`. **Benefits:** The comparison of operators via `qml.equal` is more complete. **Related GitHub Issues:** #4842
mudit2812
pushed a commit
that referenced
this pull request
Jan 19, 2024
…der (#4944) **Context:** As long as the mapping of control wires to control values is the same, the order of control wires doesn't matter when comparing two Controlled operators, but the current implementation of `qml.equal` doesn't consider this. This currently returns False, because the wires differ in order: ``` base1 = qml.PauliX(wires=0) base2 = qml.PauliX(wires=0) op1 = qml.ops.op_math.Controlled(base1, control_wires=[1, 2]) op2 = qml.ops.op_math.Controlled(base2, control_wires=[2, 1]) print(qml.equal(op1, op2)) ``` **Description of the Change:** Instead of comparing the operator wires and the control values, we compare the `work_wires` of the two operators, and we compare dictionaries of `{wire1: value1, wire2: value2...}`. **Benefits:** The comparison of operators via `qml.equal` is more complete. **Related GitHub Issues:** #4842
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context:
As long as the mapping of control wires to control values is the same, the order of control wires doesn't matter when comparing two Controlled operators, but the current implementation of
qml.equaldoesn't consider this. This currently returns False, because the wires differ in order:Description of the Change:
Instead of comparing the operator wires and the control values, we compare the
work_wiresof the two operators, and we compare dictionaries of{wire1: value1, wire2: value2...}.Benefits:
The comparison of operators via
qml.equalis more complete.Related GitHub Issues:
#4842