Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add min version for Catalyst to qml.compiler #4979

Merged
merged 18 commits into from Jan 5, 2024

Conversation

maliasadi
Copy link
Member

@maliasadi maliasadi commented Jan 2, 2024

The new PL version should check that the Catalyst version, if installed, is at least v0.4.0.

Note there are a couple of TODOs to address after releasing Catalyst v0.4.0.

[sc-52634]

Updates PennyLane as we're entering a new development version (release
of v0.34.0 coming up):

- Create changelog-dev.md
- Add changelog-dev.md to release-notes.md
- Increments the version number to v0.35.0-dev
- Update rc_sync.yml to replace the previous release manager

It **must not be merged** before the creation of the release candidate
branch 0.34.0

```
rc    master
|     |
|     - (**THIS PR**) changelog and version updates for 0.35.0-dev
|    /
|   /
|  /
| /
|/
- changelog and version updates for 0.34.0 RC branch
|
| 
```
Copy link
Contributor

github-actions bot commented Jan 2, 2024

Hello. You may have forgotten to update the changelog!
Please edit doc/releases/changelog-dev.md with:

  • A one-to-two sentence description of the change. You may include a small working example for new features.
  • A link back to this PR.
  • Your name (or GitHub username) in the contributors section.

@maliasadi maliasadi marked this pull request as ready for review January 2, 2024 21:22
Copy link
Contributor

@timmysilv timmysilv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

made some suggestions to use semantic-version to avoid adding another dependency to PennyLane (not sure if I got the syntax exactly right, but I think it should do)

pennylane/compiler/compiler.py Outdated Show resolved Hide resolved
pennylane/compiler/compiler.py Outdated Show resolved Hide resolved
setup.py Outdated Show resolved Hide resolved
.github/workflows/interface-unit-tests.yml Outdated Show resolved Hide resolved
@maliasadi maliasadi changed the base branch from master to v0.34.0-rc0 January 3, 2024 18:11
@maliasadi maliasadi added this to the v0.34 milestone Jan 3, 2024
Copy link
Contributor

@timmysilv timmysilv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉

Copy link
Contributor

@lillian542 lillian542 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @maliasadi! 🚀

Copy link

codecov bot commented Jan 4, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

❗ No coverage uploaded for pull request base (v0.34.0-rc0@accb35f). Click here to learn what that means.

Additional details and impacted files
@@              Coverage Diff               @@
##             v0.34.0-rc0    #4979   +/-   ##
==============================================
  Coverage               ?   99.66%           
==============================================
  Files                  ?      392           
  Lines                  ?    35285           
  Branches               ?        0           
==============================================
  Hits                   ?    35168           
  Misses                 ?      117           
  Partials               ?        0           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@lillian542 lillian542 self-requested a review January 4, 2024 19:30
@maliasadi maliasadi requested a review from dime10 January 4, 2024 20:48
Copy link
Contributor

@dime10 dime10 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @maliasadi :)

pennylane/compiler/compiler.py Outdated Show resolved Hide resolved
tests/test_compiler.py Outdated Show resolved Hide resolved
tests/test_compiler.py Outdated Show resolved Hide resolved
pennylane/compiler/compiler.py Outdated Show resolved Hide resolved
tests/test_compiler.py Outdated Show resolved Hide resolved
@maliasadi maliasadi requested a review from dime10 January 5, 2024 14:58
Copy link
Contributor

@dime10 dime10 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great 🙂

@lillian542 lillian542 enabled auto-merge (squash) January 5, 2024 17:29
@lillian542 lillian542 merged commit 30a4634 into v0.34.0-rc0 Jan 5, 2024
34 checks passed
@lillian542 lillian542 deleted the maa/catalyst-min-version branch January 5, 2024 19:31

if name == "catalyst":
installed_catalyst_version = metadata.version("pennylane-catalyst")
print(installed_catalyst_version)
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🦖

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants