Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Minor MPL drawing sizing fix #4987

Merged
merged 3 commits into from Jan 4, 2024
Merged

Minor MPL drawing sizing fix #4987

merged 3 commits into from Jan 4, 2024

Conversation

albi3ro
Copy link
Contributor

@albi3ro albi3ro commented Jan 3, 2024

In PR #4957 , I added extra space to the matplotlib figure and axes so they could accommodate classical wires without looking odd.

But the extra space was always there, whether or not we actually had any classical wires. This cropped up when comparing figure outputs from the qml demos.

This just makes the extra space conditional on the existence of classical wires, so that previous images will continue looking the same.

@albi3ro albi3ro requested a review from timmysilv January 3, 2024 23:26
Copy link
Contributor

github-actions bot commented Jan 3, 2024

Hello. You may have forgotten to update the changelog!
Please edit doc/releases/changelog-dev.md with:

  • A one-to-two sentence description of the change. You may include a small working example for new features.
  • A link back to this PR.
  • Your name (or GitHub username) in the contributors section.

Copy link

codecov bot commented Jan 3, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

❗ No coverage uploaded for pull request base (v0.34.0-rc0@147d565). Click here to learn what that means.

Additional details and impacted files
@@              Coverage Diff               @@
##             v0.34.0-rc0    #4987   +/-   ##
==============================================
  Coverage               ?   99.67%           
==============================================
  Files                  ?      392           
  Lines                  ?    35289           
  Branches               ?        0           
==============================================
  Hits                   ?    35174           
  Misses                 ?      115           
  Partials               ?        0           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@timmysilv timmysilv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

awesome, ty!

@albi3ro albi3ro merged commit 11abffc into v0.34.0-rc0 Jan 4, 2024
34 checks passed
@albi3ro albi3ro deleted the figsize-fix branch January 4, 2024 02:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants