Measuring projectors on a state with parameter broadcasting. #4993
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hello. You may have forgotten to update the changelog!
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## v0.34.0-rc0 #4993 +/- ##
==============================================
Coverage ? 99.66%
==============================================
Files ? 392
Lines ? 35268
Branches ? 0
==============================================
Hits ? 35151
Misses ? 117
Partials ? 0 ☔ View full report in Codecov by Sentry. |
timmysilv
reviewed
Jan 4, 2024
Co-authored-by: Matthew Silverman <matthews@xanadu.ai>
I think its much more likely that this will fix any plugins that are also having this issue. |
timmysilv
approved these changes
Jan 4, 2024
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR supercedes #4971 and fixes #4975 . [sc-52681]
As this is a high priority bug and we have an upcoming release, I am fixing this here.
Nicely this bug can be fixed by removing the specialized logic and just always just the default logic. This will be easier to maintain and extend in the future.