Replacement of PR "Improve runtime performance of QCUT fragment expansion #4782" #5005
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hello. You may have forgotten to update the changelog!
|
mlxd
changed the title
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #5005 +/- ##
==========================================
- Coverage 99.67% 99.66% -0.01%
==========================================
Files 394 394
Lines 35670 35399 -271
==========================================
- Hits 35554 35282 -272
- Misses 116 117 +1 ☔ View full report in Codecov by Sentry. |
mudit2812
approved these changes
Jan 12, 2024
albi3ro
approved these changes
Jan 12, 2024
mudit2812
pushed a commit
that referenced
this pull request
Jan 19, 2024
…sion #4782" (#5005) ### Before submitting Please complete the following checklist when submitting a PR: - [x] All new features must include a unit test. If you've fixed a bug or added code that should be tested, add a test to the test directory! - [x] All new functions and code must be clearly commented and documented. If you do make documentation changes, make sure that the docs build and render correctly by running `make docs`. - [x] Ensure that the test suite passes, by running `make test`. - [x] Add a new entry to the `doc/releases/changelog-dev.md` file, summarizing the change, and including a link back to the PR. - [x] The PennyLane source code conforms to [PEP8 standards](https://www.python.org/dev/peps/pep-0008/). We check all of our code against [Pylint](https://www.pylint.org/). To lint modified files, simply `pip install pylint`, and then run `pylint pennylane/path/to/file.py`. When all the above are checked, delete everything above the dashed line and fill in the pull request template. ------------------------------------------------------------------------------------------------------------ **Context:** Replacement of PR #4782 For large circuits performing the PrepareNode and MeasureNode staged replacements during circuit cutting fragments can be expensive when serialising on an AnnotatedQueue, due to the queuing mechanism overheads. **Description of the Change**: This PR replaces an internally used AnnotatedQueue with a directly built QuantumScript object. **Benefits**: Provides speed-ups for circuit-cutting stage for a large number of circuit fragments. Observed 2x speed-up for a given workload. **Possible Drawbacks**: **Related GitHub Issues**:
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before submitting
Please complete the following checklist when submitting a PR:
All new features must include a unit test.
If you've fixed a bug or added code that should be tested, add a test to the
test directory!
All new functions and code must be clearly commented and documented.
If you do make documentation changes, make sure that the docs build and
render correctly by running
make docs.Ensure that the test suite passes, by running
make test.Add a new entry to the
doc/releases/changelog-dev.mdfile, summarizing thechange, and including a link back to the PR.
The PennyLane source code conforms to
PEP8 standards.
We check all of our code against Pylint.
To lint modified files, simply
pip install pylint, and thenrun
pylint pennylane/path/to/file.py.When all the above are checked, delete everything above the dashed
line and fill in the pull request template.
Context: Replacement of PR #4782
For large circuits performing the PrepareNode and MeasureNode staged replacements during circuit cutting fragments can be expensive when serialising on an AnnotatedQueue, due to the queuing mechanism overheads.
Description of the Change: This PR replaces an internally used AnnotatedQueue with a directly built QuantumScript object.
Benefits: Provides speed-ups for circuit-cutting stage for a large number of circuit fragments. Observed 2x speed-up for a given workload.
Possible Drawbacks:
Related GitHub Issues: