fix keraslayer set and get attr dunders #5008
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context:
Fixes #4999. We re-implemented the default
setattr
andgetattr
dunders forKerasLayer
(needed to modify the QNode saved on the layer) but we should have calledsuper()
, becausekeras.layer.Layer
has its own custom implementation that we needed to use. OurTorchLayer
already callssuper
in these cases.Note - our existing tests were passing because the weights used had custom names ("w1", "w2", etc.), and this issue only comes up when your weights are named "weights" (which is a rather common case, I'm sure).
Description of the Change:
get/set-attr
dunders with a call tosuper()
Benefits:
Models using
KerasLayer
can be saved and loaded properly!Possible Drawbacks:
N/A
Related GitHub Issues:
Reported initially in #4999, same as #4611 but for Keras