Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove observable.return_type #5044

Merged
merged 4 commits into from Jan 12, 2024
Merged

remove observable.return_type #5044

merged 4 commits into from Jan 12, 2024

Conversation

timmysilv
Copy link
Contributor

completing the deprecation cycle. will break braket-*-latest as they haven't moved yet.

[sc-51274]

@timmysilv timmysilv requested a review from a team January 11, 2024 19:55
Copy link

codecov bot commented Jan 11, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (c01cb4b) 99.67% compared to head (4dc9694) 99.66%.
Report is 3 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #5044      +/-   ##
==========================================
- Coverage   99.67%   99.66%   -0.01%     
==========================================
  Files         394      394              
  Lines       35670    35385     -285     
==========================================
- Hits        35554    35268     -286     
- Misses        116      117       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@albi3ro albi3ro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Always happy to prune :)

@timmysilv timmysilv requested a review from a team January 12, 2024 14:48
Copy link
Contributor

@lillian542 lillian542 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should probably remind the Braket team that this is happening at the meeting next week

# Conflicts:
#	doc/releases/changelog-dev.md
@timmysilv timmysilv enabled auto-merge (squash) January 12, 2024 16:28
@timmysilv timmysilv merged commit 4ff93d6 into master Jan 12, 2024
35 checks passed
@timmysilv timmysilv deleted the remove-obs-return-type branch January 12, 2024 16:46
mudit2812 pushed a commit that referenced this pull request Jan 19, 2024
completing the deprecation cycle. will break braket-*-latest as they
haven't moved yet.

[sc-51274]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants