New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Deprecate Operator.validate_subspace(subspace) #5067
Conversation
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## master #5067 +/- ##
==========================================
- Coverage 99.67% 99.66% -0.01%
==========================================
Files 394 394
Lines 35670 35465 -205
==========================================
- Hits 35554 35347 -207
- Misses 116 118 +2 ☔ View full report in Codecov by Sentry. |
[sc-51601] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
awesome! just need to fix the duplicate contributors but lgtm
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @Alex-Preciado!
Co-authored-by: Thomas R. Bromley <49409390+trbromley@users.noreply.github.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @Alex-Preciado ! Congrats on the first PR 🎉
This PR relocates the `Operator.validate_subspace()` method to the `qml.ops.qutrit.parametric_ops` module. ### Context: `Operator.validate_subspace(subspace)` is only employed under a specific set of qutrit operators and is therefore not needed as an official part of the Operator interface. --------- Co-authored-by: Thomas R. Bromley <49409390+trbromley@users.noreply.github.com>
This PR relocates the
Operator.validate_subspace()
method to theqml.ops.qutrit.parametric_ops
module.Context:
Operator.validate_subspace(subspace)
is only employed under a specific set of qutrit operators and is therefore not needed as an official part of the Operator interface.