Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecate Operator.validate_subspace(subspace) #5067

Merged
merged 8 commits into from Jan 17, 2024

Conversation

Alex-Preciado
Copy link
Contributor

@Alex-Preciado Alex-Preciado commented Jan 15, 2024

This PR relocates the Operator.validate_subspace() method to the qml.ops.qutrit.parametric_ops module.

Context:

Operator.validate_subspace(subspace) is only employed under a specific set of qutrit operators and is therefore not needed as an official part of the Operator interface.

Copy link

codecov bot commented Jan 15, 2024

Codecov Report

Attention: 2 lines in your changes are missing coverage. Please review.

Comparison is base (c01cb4b) 99.67% compared to head (98ca7a1) 99.66%.
Report is 20 commits behind head on master.

Files Patch % Lines
pennylane/workflow/jacobian_products.py 91.30% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #5067      +/-   ##
==========================================
- Coverage   99.67%   99.66%   -0.01%     
==========================================
  Files         394      394              
  Lines       35670    35465     -205     
==========================================
- Hits        35554    35347     -207     
- Misses        116      118       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Alex-Preciado Alex-Preciado removed the request for review from timmysilv January 15, 2024 22:14
@Alex-Preciado
Copy link
Contributor Author

[sc-51601]

Copy link
Contributor

@timmysilv timmysilv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

awesome! just need to fix the duplicate contributors but lgtm

doc/releases/changelog-dev.md Show resolved Hide resolved
Copy link
Contributor

@trbromley trbromley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @Alex-Preciado!

doc/releases/changelog-dev.md Outdated Show resolved Hide resolved
pennylane/ops/qutrit/parametric_ops.py Outdated Show resolved Hide resolved
Alex-Preciado and others added 2 commits January 16, 2024 16:47
Co-authored-by: Thomas R. Bromley <49409390+trbromley@users.noreply.github.com>
@Alex-Preciado Alex-Preciado changed the title Deprecate Operator.validate_subspace() Deprecate Operator.validate_subspace(subspace) Jan 16, 2024
Copy link
Contributor

@mudit2812 mudit2812 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @Alex-Preciado ! Congrats on the first PR 🎉

@albi3ro albi3ro merged commit f7433e4 into master Jan 17, 2024
34 of 35 checks passed
@albi3ro albi3ro deleted the deprecate_validate_subspace branch January 17, 2024 14:41
mudit2812 pushed a commit that referenced this pull request Jan 19, 2024
This PR relocates the `Operator.validate_subspace()` method to the
`qml.ops.qutrit.parametric_ops` module.

### Context:
`Operator.validate_subspace(subspace)` is only employed under a specific
set of qutrit operators and is therefore not needed as an official part
of the Operator interface.

---------

Co-authored-by: Thomas R. Bromley <49409390+trbromley@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants