CosineWindow expands over all circuit wires #5080
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
timmysilv
commented
Jan 17, 2024
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #5080 +/- ##
==========================================
- Coverage 99.68% 99.68% -0.01%
==========================================
Files 394 394
Lines 35733 35466 -267
==========================================
- Hits 35622 35354 -268
- Misses 111 112 +1 ☔ View full report in Codecov by Sentry. |
mudit2812
pushed a commit
that referenced
this pull request
Jan 19, 2024
**Context:** When StatePrepBase operations are used at the start of a circuit on a subset of all circuit wires, we want to initialize the system state with all other wires set to the zero-state. `CosineWindow` did not implement this edge-case, and only returned a state spanning the subspace of the wires it acts on regardless of wire order given (it only used `wire_order` for transposition, not expansion) **Description of the Change:** Update `CosineWindow.state_vector` to expand over unused wires present in the provided `wire_order` Master: ```pycon >>> qml.CosineWindow(wires=[0, 1]).state_vector(wire_order=[0, 1, 2]).shape (2, 2) ``` Branch: ```pycon >>> qml.CosineWindow(wires=[0, 1]).state_vector(wire_order=[0, 1, 2]).shape (2, 2, 2) ``` **Benefits:** No more unexpected errors when `CosineWindow` is used as a state-prep operation on a subset of wires with DefaultQubit **Possible Drawbacks:** N/A [sc-54223]
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context:
When StatePrepBase operations are used at the start of a circuit on a subset of all circuit wires, we want to initialize the system state with all other wires set to the zero-state.
CosineWindowdid not implement this edge-case, and only returned a state spanning the subspace of the wires it acts on regardless of wire order given (it only usedwire_orderfor transposition, not expansion)Description of the Change:
Update
CosineWindow.state_vectorto expand over unused wires present in the providedwire_orderMaster:
Branch:
Benefits:
No more unexpected errors when
CosineWindowis used as a state-prep operation on a subset of wires with DefaultQubitPossible Drawbacks:
N/A
[sc-54223]