restore test for stop_recording
cleanup
#5094
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This was originally added in #3182, but I only put the test in
test_tape.py
, so it was accidentally pruned in #3281 (anagram PR!) which isn't ideal. I'm putting it back intest_queuing.py
where it truly belongs.I know this PR seems a bit insignificant, but I remember this bug coming up and I don't want it to resurface because of a lack of testing. Plus, the
finally
is much prettier than writing the cleanup code twice 😄Not bothering with a changelog entry, but can add if we feel strongly about it