Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

restore test for stop_recording cleanup #5094

Merged
merged 3 commits into from Jan 23, 2024
Merged

Conversation

timmysilv
Copy link
Contributor

@timmysilv timmysilv commented Jan 23, 2024

This was originally added in #3182, but I only put the test in test_tape.py, so it was accidentally pruned in #3281 (anagram PR!) which isn't ideal. I'm putting it back in test_queuing.py where it truly belongs.

I know this PR seems a bit insignificant, but I remember this bug coming up and I don't want it to resurface because of a lack of testing. Plus, the finally is much prettier than writing the cleanup code twice 😄

Not bothering with a changelog entry, but can add if we feel strongly about it

Copy link
Contributor

Hello. You may have forgotten to update the changelog!
Please edit doc/releases/changelog-dev.md with:

  • A one-to-two sentence description of the change. You may include a small working example for new features.
  • A link back to this PR.
  • Your name (or GitHub username) in the contributors section.

Copy link

codecov bot commented Jan 23, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (d94c40c) 99.68% compared to head (079bdc3) 99.67%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #5094      +/-   ##
==========================================
- Coverage   99.68%   99.67%   -0.02%     
==========================================
  Files         392      392              
  Lines       35847    35572     -275     
==========================================
- Hits        35735    35457     -278     
- Misses        112      115       +3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@timmysilv timmysilv requested a review from a team January 23, 2024 15:39
pennylane/queuing.py Outdated Show resolved Hide resolved
@timmysilv timmysilv enabled auto-merge (squash) January 23, 2024 22:03
@timmysilv timmysilv merged commit 69098c4 into master Jan 23, 2024
35 checks passed
@timmysilv timmysilv deleted the add-back-recording-test branch January 23, 2024 22:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants