Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fail CI if coverage fails to upload #5101

Merged
merged 2 commits into from Jan 24, 2024
Merged

Conversation

timmysilv
Copy link
Contributor

Context:
When the Codecov upload action fails because of network issues or the like, the action reports as passed, then the codecov action stays as "Expected" forevermore. This is worse than a failure because it continues to block us but we don't immediately know why. If we knew, we could just re-run it when we find out.

Description of the Change:
Set the codecov upload action to fail on failure 😄

Benefits:
We will know when it fails to upload, and we can re-run the upload task manually

Possible Drawbacks:
External contributors might hit this, and although the old ways were also bad, this might be a bit more visibly frightening if you don't know why you got a big red ❌

Copy link
Contributor

Hello. You may have forgotten to update the changelog!
Please edit doc/releases/changelog-dev.md with:

  • A one-to-two sentence description of the change. You may include a small working example for new features.
  • A link back to this PR.
  • Your name (or GitHub username) in the contributors section.

@timmysilv timmysilv requested a review from a team January 24, 2024 17:08
Copy link

codecov bot commented Jan 24, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (4e2e344) 99.68% compared to head (71501d2) 99.67%.
Report is 1 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #5101      +/-   ##
==========================================
- Coverage   99.68%   99.67%   -0.02%     
==========================================
  Files         392      392              
  Lines       35844    35578     -266     
==========================================
- Hits        35732    35463     -269     
- Misses        112      115       +3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@lillian542 lillian542 requested a review from a team January 24, 2024 18:49
Copy link
Contributor

@mudit2812 mudit2812 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Excited to see this change. Too bad we can't test it out

@timmysilv timmysilv merged commit 5cfdedd into master Jan 24, 2024
35 checks passed
@timmysilv timmysilv deleted the codecov-upload-error-failure branch January 24, 2024 19:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants