Pin black to 23.12. #5112
Merged
Pin black to 23.12. #5112
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hello. You may have forgotten to update the changelog!
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #5112 +/- ##
==========================================
- Coverage 99.68% 99.68% -0.01%
==========================================
Files 393 391 -2
Lines 35874 35524 -350
==========================================
- Hits 35762 35412 -350
Misses 112 112 ☔ View full report in Codecov by Sentry. |
AmintorDusko
approved these changes
Jan 26, 2024
Alex-Preciado
approved these changes
Jan 26, 2024
There was a problem hiding this comment.
Thanks @vincentmr !! Let's pin for now to remove the blocker. We can prepare a format PR next week.
albi3ro
pushed a commit
that referenced
this pull request
Jan 31, 2024
**Context:** See #5112. New version of `black` came out, and it auto-formatted a bunch of files. Most of these changes are backwards-compatible (with previous versions of `black`) but not all, so it was non-trivial **Description of the Change:** Did the following: ```shell pip install -U black make format git add . pip install black~=23.12 make format ``` At this point, all unstaged changes are non-backwards-compatible lines. So, I tweaked those lines, ran `make format` to make sure they were good with old black, then re-ran the above set of commands to ensure it's forwards-compatible too. I'll inline comment each actual change I made. **Benefits:** - devs can use whatever version of `black` they choose, including the new one - less pinned packages == more pennylane spirit **Possible Drawbacks:** N/A [sc-55823]
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before submitting
Please complete the following checklist when submitting a PR:
All new features must include a unit test.
If you've fixed a bug or added code that should be tested, add a test to the
test directory!
All new functions and code must be clearly commented and documented.
If you do make documentation changes, make sure that the docs build and
render correctly by running
make docs.Ensure that the test suite passes, by running
make test.Add a new entry to the
doc/releases/changelog-dev.mdfile, summarizing thechange, and including a link back to the PR.
The PennyLane source code conforms to
PEP8 standards.
We check all of our code against Pylint.
To lint modified files, simply
pip install pylint, and thenrun
pylint pennylane/path/to/file.py.When all the above are checked, delete everything above the dashed
line and fill in the pull request template.
Context:
Black just released v24, which changes about 50 files.
Description of the Change:
Pin Black to v23.12.
Benefits:
Everyone gets the same Black version. Fewer formatting changes to track in the future.
Possible Drawbacks:
Related GitHub Issues: