Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add abstract AlgorithmicError class #5115

Merged
merged 27 commits into from Feb 12, 2024
Merged

Add abstract AlgorithmicError class #5115

merged 27 commits into from Feb 12, 2024

Conversation

Jaybsoni
Copy link
Contributor

Context:
The first of a few PRs adding error propagation functionality to PennyLane

Description of the Change:
Add abstract AlgorithmicError class

Copy link
Contributor

Hello. You may have forgotten to update the changelog!
Please edit doc/releases/changelog-dev.md with:

  • A one-to-two sentence description of the change. You may include a small working example for new features.
  • A link back to this PR.
  • Your name (or GitHub username) in the contributors section.

@Jaybsoni
Copy link
Contributor Author

[sc-55439]

@Jaybsoni Jaybsoni added the review-ready 👌 PRs which are ready for review by someone from the core team. label Jan 26, 2024
@Jaybsoni
Copy link
Contributor Author

[sc-55154]

Copy link

codecov bot commented Jan 26, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (127beeb) 99.69% compared to head (8c34c92) 99.68%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #5115      +/-   ##
==========================================
- Coverage   99.69%   99.68%   -0.01%     
==========================================
  Files         394      395       +1     
  Lines       36075    35815     -260     
==========================================
- Hits        35964    35703     -261     
- Misses        111      112       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Jaybsoni and others added 2 commits January 29, 2024 17:44
Co-authored-by: Thomas R. Bromley <49409390+trbromley@users.noreply.github.com>
pennylane/resource/error.py Outdated Show resolved Hide resolved
pennylane/resource/error.py Outdated Show resolved Hide resolved
tests/resource/test_error.py Outdated Show resolved Hide resolved
tests/resource/test_error.py Outdated Show resolved Hide resolved
pennylane/resource/error.py Show resolved Hide resolved
pennylane/resource/error.py Outdated Show resolved Hide resolved
pennylane/resource/error.py Show resolved Hide resolved
tests/resource/test_error.py Outdated Show resolved Hide resolved
@codecov-commenter
Copy link

codecov-commenter commented Feb 6, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (506bce2) 99.68% compared to head (334490a) 99.68%.
Report is 2 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #5115      +/-   ##
==========================================
- Coverage   99.68%   99.68%   -0.01%     
==========================================
  Files         395      396       +1     
  Lines       36455    36191     -264     
==========================================
- Hits        36341    36076     -265     
- Misses        114      115       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

tests/resource/test_error.py Outdated Show resolved Hide resolved
@Jaybsoni Jaybsoni requested a review from soranjh February 7, 2024 17:21
Copy link
Contributor

@soranjh soranjh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @Jaybsoni, looks good.

pennylane/resource/error.py Outdated Show resolved Hide resolved
Copy link
Contributor

@AmintorDusko AmintorDusko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nothing more to add. Thank you for that!

Copy link
Contributor

@DSGuala DSGuala left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. I think I convinced myself that AlgorithmicError works as the name.

pennylane/resource/__init__.py Show resolved Hide resolved
pennylane/resource/error.py Outdated Show resolved Hide resolved
Jaybsoni and others added 2 commits February 12, 2024 10:56
Co-authored-by: Diego <67476785+DSGuala@users.noreply.github.com>
pennylane/resource/error.py Outdated Show resolved Hide resolved
@Jaybsoni Jaybsoni enabled auto-merge (squash) February 12, 2024 16:04
@Jaybsoni Jaybsoni merged commit 84f9cfd into master Feb 12, 2024
35 checks passed
@Jaybsoni Jaybsoni deleted the algo_error branch February 12, 2024 20:45
Gabriel-Bottrill pushed a commit to QSAR-UBC/pennylane_qutrit_mixed that referenced this pull request Feb 14, 2024
**Context:**
The first of a few PRs adding error propagation functionality to
PennyLane

**Description of the Change:**
Add abstract `AlgorithmicError` class

---------

Co-authored-by: Thomas R. Bromley <49409390+trbromley@users.noreply.github.com>
Co-authored-by: Amintor Dusko <87949283+AmintorDusko@users.noreply.github.com>
Co-authored-by: soranjh <40344468+soranjh@users.noreply.github.com>
Co-authored-by: Diego <67476785+DSGuala@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
review-ready 👌 PRs which are ready for review by someone from the core team.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants