[BUGFIX] qml.equal via pauli_rep #5177
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hello. You may have forgotten to update the changelog!
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #5177 +/- ##
==========================================
- Coverage 99.68% 99.67% -0.01%
==========================================
Files 394 394
Lines 36306 36051 -255
==========================================
- Hits 36191 35935 -256
- Misses 115 116 +1 ☔ View full report in Codecov by Sentry. |
mudit2812
reviewed
Feb 8, 2024
Qottmann
commented
Feb 8, 2024
| @@ -269,12 +269,12 @@ def _equal_operators( | |||
| # pylint: disable=unused-argument, protected-access | |||
| def _equal_prod_and_sum(op1: CompositeOp, op2: CompositeOp, **kwargs): | |||
| """Determine whether two Prod or Sum objects are equal""" | |||
| if len(op1.operands) != len(op2.operands): | |||
There was a problem hiding this comment.
simply changed the order
mudit2812
reviewed
Feb 8, 2024
mudit2812
reviewed
Feb 8, 2024
mudit2812
reviewed
Feb 8, 2024
Co-authored-by: Mudit Pandey <mudit.pandey@xanadu.ai>
mudit2812
reviewed
Feb 8, 2024
mudit2812
approved these changes
Feb 8, 2024
albi3ro
approved these changes
Feb 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Potential fix for #5162 and many other related issues
Simply compares the pauli_rep between operators, when both have one.
Original Story: [sc-56269]
Duplicate: [sc-56466]