Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix QubitDensityMatrix for subsystems with jit on default.mixed #5236

Merged
merged 5 commits into from Feb 26, 2024

Conversation

timmysilv
Copy link
Contributor

@timmysilv timmysilv commented Feb 20, 2024

I started this in #5203, but missed the case when it's only applied to a subset of the device wires. This handles that case now as well

Fixes #5235

@timmysilv timmysilv requested a review from a team February 20, 2024 20:20
Copy link

codecov bot commented Feb 20, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

❗ No coverage uploaded for pull request base (v0.35.0-rc0@5073c25). Click here to learn what that means.

Additional details and impacted files
@@              Coverage Diff               @@
##             v0.35.0-rc0    #5236   +/-   ##
==============================================
  Coverage               ?   99.67%           
==============================================
  Files                  ?      399           
  Lines                  ?    36585           
  Branches               ?        0           
==============================================
  Hits                   ?    36467           
  Misses                 ?      118           
  Partials               ?        0           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@timmysilv timmysilv requested a review from a team February 20, 2024 20:44
@trbromley trbromley added this to the v0.35 milestone Feb 23, 2024
@trbromley trbromley added the bug 🐛 Something isn't working label Feb 23, 2024
@timmysilv timmysilv changed the base branch from master to v0.35.0-rc0 February 26, 2024 16:41
@timmysilv timmysilv enabled auto-merge (squash) February 26, 2024 16:48
@timmysilv timmysilv merged commit a1da0ed into v0.35.0-rc0 Feb 26, 2024
39 checks passed
@timmysilv timmysilv deleted the fix-qubit-density-matrix-v2 branch February 26, 2024 18:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug 🐛 Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] Uncompatibility between "qml.density_matrix" and "default.mixed" in jax.jit
4 participants