Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Bravyi-Kitaev mapping #5390

Merged
merged 40 commits into from
Apr 11, 2024
Merged

Add Bravyi-Kitaev mapping #5390

merged 40 commits into from
Apr 11, 2024

Conversation

ddhawan11
Copy link
Contributor

Context:
The PR adds Bravyi-Kitaev mapping

Description of the Change:

Benefits:
New mapping scheme from fermionic to qubit Hamiltonian

Possible Drawbacks:

Related GitHub Issues:

@ddhawan11 ddhawan11 added the qchem ⚛️ Related to the QChem package label Mar 15, 2024
@ddhawan11 ddhawan11 requested a review from soranjh March 15, 2024 15:53
@ddhawan11 ddhawan11 self-assigned this Mar 19, 2024
soranjh
soranjh requested changes Apr 1, 2024
View reviewed changes
Copy link
Contributor

@soranjh soranjh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @ddhawan11, looks good. Left some comments and questions.

doc/releases/changelog-dev.md Outdated Show resolved Hide resolved
pennylane/fermi/conversion.py Outdated Show resolved Hide resolved
pennylane/fermi/conversion.py Outdated Show resolved Hide resolved
pennylane/fermi/conversion.py Outdated Show resolved Hide resolved
pennylane/fermi/conversion.py Outdated Show resolved Hide resolved
pennylane/fermi/conversion.py Outdated Show resolved Hide resolved
pennylane/fermi/conversion.py Outdated Show resolved Hide resolved
pennylane/fermi/conversion.py Outdated Show resolved Hide resolved
pennylane/fermi/conversion.py Outdated Show resolved Hide resolved
tests/fermi/test_bravyi_kitaev.py Outdated Show resolved Hide resolved
ddhawan11 and others added 5 commits April 2, 2024 02:21
@ddhawan11 @soranjh
Update pennylane/fermi/conversion.py
6a79e63 
Co-authored-by: soranjh <40344468+soranjh@users.noreply.github.com>
@ddhawan11 @soranjh
Update pennylane/fermi/conversion.py
fcec3db 
Co-authored-by: soranjh <40344468+soranjh@users.noreply.github.com>
@ddhawan11 @soranjh
Update pennylane/fermi/conversion.py
cffe8e9 
Co-authored-by: soranjh <40344468+soranjh@users.noreply.github.com>
@ddhawan11 @soranjh
Update pennylane/fermi/conversion.py
4544c5c 
Co-authored-by: soranjh <40344468+soranjh@users.noreply.github.com>
@ddhawan11 @soranjh
Update pennylane/fermi/conversion.py
84f6139 
Co-authored-by: soranjh <40344468+soranjh@users.noreply.github.com>
@ddhawan11 ddhawan11 changed the title [WIP] add Bravyi-Kitaev mapping add Bravyi-Kitaev mapping Apr 2, 2024
@ddhawan11 ddhawan11 marked this pull request as ready for review April 2, 2024 08:31
trbromley
trbromley reviewed Apr 2, 2024
View reviewed changes
Copy link
Contributor

@trbromley trbromley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, thanks @ddhawan11!

pennylane/fermi/conversion.py Show resolved Hide resolved
pennylane/fermi/conversion.py Outdated Show resolved Hide resolved
@soranjh soranjh changed the title add Bravyi-Kitaev mapping Add Bravyi-Kitaev mapping Apr 3, 2024
austingmhuang
austingmhuang reviewed Apr 3, 2024
View reviewed changes
Copy link
Contributor

@austingmhuang austingmhuang left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great @ddhawan11 ! I left some small comments, but honestly just some stylistic changes.

pennylane/fermi/conversion.py Outdated Show resolved Hide resolved
pennylane/fermi/conversion.py Outdated Show resolved Hide resolved
pennylane/fermi/conversion.py Outdated Show resolved Hide resolved
pennylane/fermi/conversion.py Outdated Show resolved Hide resolved
ddhawan11 and others added 4 commits April 4, 2024 04:53
@ddhawan11 @austingmhuang
Update pennylane/fermi/conversion.py
dd8cd8c 
Co-authored-by: Austin Huang <65315367+austingmhuang@users.noreply.github.com>
@ddhawan11 @austingmhuang
Update pennylane/fermi/conversion.py
7336939 
Co-authored-by: Austin Huang <65315367+austingmhuang@users.noreply.github.com>
@ddhawan11
Reviewed suggestions
a497a09
@ddhawan11
Merge branch 'master' into bravyi_kitaev_mapping
d03fda1
@ddhawan11
Copy link
Contributor Author

[sc-38014]

ddhawan11 and others added 4 commits April 4, 2024 06:58
@ddhawan11 @trbromley
Update pennylane/fermi/conversion.py
7e01618 
Co-authored-by: Thomas R. Bromley <49409390+trbromley@users.noreply.github.com>
@ddhawan11 @soranjh
Update pennylane/fermi/conversion.py
507bcf6 
Co-authored-by: soranjh <40344468+soranjh@users.noreply.github.com>
@ddhawan11 @soranjh
Update pennylane/fermi/conversion.py
c7c91fd 
Co-authored-by: soranjh <40344468+soranjh@users.noreply.github.com>
@ddhawan11 @soranjh
Update pennylane/fermi/conversion.py
07fabbe 
Co-authored-by: soranjh <40344468+soranjh@users.noreply.github.com>
ddhawan11 and others added 3 commits April 5, 2024 06:22
@ddhawan11 @soranjh
Update doc/releases/changelog-dev.md
a267c47 
Co-authored-by: soranjh <40344468+soranjh@users.noreply.github.com>
@ddhawan11 @austingmhuang
Update pennylane/fermi/conversion.py
0ae5dc2 
Co-authored-by: Austin Huang <65315367+austingmhuang@users.noreply.github.com>
@ddhawan11 @soranjh
Update pennylane/fermi/conversion.py
c04e3cb 
Co-authored-by: soranjh <40344468+soranjh@users.noreply.github.com>
@ddhawan11
Copy link
Contributor Author

ddhawan11 commented Apr 5, 2024 •
edited

Looks good to me (other than some minor details). I didn't write this but could explain a bit further what "binary range" is since people may be more familiar with number of modes instead. I don't think it matters that much though, just a suggestion.

I think we could explain it in the demo, the number of modes are sometimes used interchangeably with number of qubits in some other packages and this gets confusing.

@ddhawan11 ddhawan11 requested a review from soranjh April 8, 2024 07:29
soranjh
soranjh reviewed Apr 8, 2024
View reviewed changes
pennylane/fermi/conversion.py Outdated Show resolved Hide resolved
pennylane/fermi/conversion.py Show resolved Hide resolved
@soranjh soranjh requested a review from trbromley April 10, 2024 14:26
@ddhawan11 ddhawan11 requested a review from soranjh April 10, 2024 16:27
trbromley
trbromley approved these changes Apr 10, 2024
View reviewed changes
Copy link
Contributor

@trbromley trbromley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @ddhawan11, great job!

doc/releases/changelog-dev.md Outdated Show resolved Hide resolved
pennylane/fermi/conversion.py Outdated Show resolved Hide resolved
soranjh
soranjh approved these changes Apr 10, 2024
View reviewed changes
Copy link
Contributor

@soranjh soranjh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks @ddhawan11.

@ddhawan11 ddhawan11 merged commit 78a2b53 into master Apr 11, 2024
38 checks passed
@ddhawan11 ddhawan11 deleted the bravyi_kitaev_mapping branch April 11, 2024 15:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@soranjh soranjh soranjh approved these changes

@trbromley trbromley trbromley approved these changes

@austingmhuang austingmhuang austingmhuang approved these changes

Assignees

@ddhawan11 ddhawan11

Labels
qchem ⚛️ Related to the QChem package
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@ddhawan11 @soranjh @trbromley @austingmhuang