Qutrit channel depolarizing #5502
Conversation
|
Hi @albi3ro, @glassnotes, @mudit2812, @trbromley. This PR is not finished, but I wanted to put it up as a draft to let you know it's here. I realized I probably should have been @ing you all in previous drafts, but I thought I would now. Also after this PR ther will be another Channel which I have drafted in this PR. |
…nylane_qutrit_mixer into qutrit_channel_depolarizing
…to checked operator and observable lists
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #5502 +/- ##
==========================================
- Coverage 99.68% 99.67% -0.01%
==========================================
Files 414 415 +1
Lines 38844 38586 -258
==========================================
- Hits 38720 38461 -259
- Misses 124 125 +1 ☔ View full report in Codecov by Sentry. |
|
Hi @albi3ro, @glassnotes, @mudit2812, @trbromley I have finished this PR, except for the failing test, I am a bit confused why that error is occurring, so I thought I would ask you all. I will add some comments to specific parts of the code now too. |
Adding suggestions Co-authored-by: Olivia Di Matteo <2068515+glassnotes@users.noreply.github.com>
There was a problem hiding this comment.
@Gabriel-Bottrill looks great - thanks for addressing everything! Just a few tiny suggestions, once incorporated I don't need to review again.
Co-authored-by: Olivia Di Matteo <2068515+glassnotes@users.noreply.github.com>
**Context:** `default.qutrit.mixed` device has been added, but only one channel has been added, [qml.QutritDepolarizingChannel](#5502), this adds the second channel to the device so the device can simulate the qutrit equivalent of amplitude damping noise. **Description of the Change:** Adds new channel module to `qml.ops.qutrit` package. Adding the second qutrit channel `QutritAmplitudeDamping`. **Benefits:** Allows for `defualt.qutrit.mixed` to simulate amplitude damping noise. Making `default.qutrit.mixed`, much more useful. **Possible Drawbacks:** N/A **Related GitHub Issues:** N/A --------- Co-authored-by: Gabriel Bottrill <bottrill@student.ubc.ca> Co-authored-by: Olivia Di Matteo <2068515+glassnotes@users.noreply.github.com> Co-authored-by: Thomas R. Bromley <49409390+trbromley@users.noreply.github.com> Co-authored-by: Mudit Pandey <mudit.pandey@xanadu.ai>
Context:
default.qutrit.mixeddevice has been added, but no channels have been added so far, this adds the first channel to the device so that it may be used for it's intended purpose of simulating noise.Description of the Change:
Adds new channel module to
qml.ops.qutritpackage. Adding the first qutrit channelQutritDepolarizingChannel.Benefits:
Allows for
defualt.qutrit.mixedto simulate depolarizing noise. Makesdefault.qutrit.mixed, much more useful.Possible Drawbacks:
N/A
Related GitHub Issues:
N/A