Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Deprecate map_batch_transform #5676

Merged
merged 18 commits into from
May 15, 2024
Merged

Deprecate map_batch_transform #5676

merged 18 commits into from
May 15, 2024

Conversation

PietropaoloFrisoni
Copy link
Contributor

@PietropaoloFrisoni PietropaoloFrisoni commented May 10, 2024 •
edited
Loading

Context: Part of deprecations and removals for pennylane-0.37

Description of the Change: Deprecating qml.transforms.map_batch_transform, since a transform can be applied directly to a batch of tapes. See #5163 and #5212.

[sc-58987]

@PietropaoloFrisoni PietropaoloFrisoni changed the title E.C. [ci skip] Deprecate map_batch_transform May 10, 2024
@PietropaoloFrisoni PietropaoloFrisoni marked this pull request as ready for review May 14, 2024 14:12
@PietropaoloFrisoni PietropaoloFrisoni marked this pull request as draft May 14, 2024 18:51
@PietropaoloFrisoni PietropaoloFrisoni marked this pull request as ready for review May 14, 2024 19:31
@codecov Codecov
Copy link

codecov bot commented May 14, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 99.67%. Comparing base (daf2d76) to head (810f7d9).

Additional details and impacted files 
@@            Coverage Diff             @@
##           master    #5676      +/-   ##
==========================================
- Coverage   99.68%   99.67%   -0.01%     
==========================================
  Files         414      414              
  Lines       38842    38552     -290     
==========================================
- Hits        38718    38427     -291     
- Misses        124      125       +1

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@albi3ro albi3ro self-requested a review May 15, 2024 16:30
@lillian542 lillian542 self-requested a review May 15, 2024 16:31
albi3ro
albi3ro approved these changes May 15, 2024
View reviewed changes
Copy link
Contributor

@albi3ro albi3ro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

lillian542
lillian542 approved these changes May 15, 2024
View reviewed changes
Copy link
Contributor

@lillian542 lillian542 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks! I made a couple of minor docs suggestions, see what you think.

pennylane/transforms/batch_transform.py Show resolved Hide resolved
pennylane/transforms/core/transform.py Outdated Show resolved Hide resolved
@PietropaoloFrisoni PietropaoloFrisoni enabled auto-merge (squash) May 15, 2024 18:35
@PietropaoloFrisoni PietropaoloFrisoni merged commit 4ee09b8 into master May 15, 2024
38 checks passed
@PietropaoloFrisoni PietropaoloFrisoni deleted the Deprecate_map_batch_transform branch May 15, 2024 18:35
Shiro-Raven pushed a commit that referenced this pull request May 15, 2024
@PietropaoloFrisoni @Shiro-Raven
Deprecate map_batch_transform (#5676)
bbe0b70 
**Context:** ***Part of  deprecations and removals for pennylane-0.37***

**Description of the Change:** Deprecating
``qml.transforms.map_batch_transform``, since a transform can be applied
directly to a batch of tapes. See #5163 and #5212.

[sc-58987]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@trbromley trbromley trbromley left review comments

@albi3ro albi3ro albi3ro approved these changes

@lillian542 lillian542 lillian542 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@PietropaoloFrisoni @albi3ro @lillian542 @trbromley