Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support dynamic measurements with debugger #5749

Merged
merged 39 commits into from
Jun 7, 2024
Merged

Support dynamic measurements with debugger #5749

merged 39 commits into from
Jun 7, 2024

Conversation

Jaybsoni
Copy link
Contributor

Context:
Follow up PR adding support for measurements

Description of the Change:

Benefits:

Possible Drawbacks:

Related GitHub Issues:

@Jaybsoni Jaybsoni added the WIP 🚧 Work-in-progress label May 28, 2024
@Jaybsoni Jaybsoni requested review from soranjh and DSGuala May 28, 2024 16:13
@github-actions GitHub Actions
Copy link
Contributor

Hello. You may have forgotten to update the changelog!
Please edit doc/releases/changelog-dev.md with:

  • A one-to-two sentence description of the change. You may include a small working example for new features.
  • A link back to this PR.
  • Your name (or GitHub username) in the contributors section.

@Jaybsoni
Copy link
Contributor Author

[sc-62244]

@codecov Codecov
Copy link

codecov bot commented May 28, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 99.67%. Comparing base (1a652a7) to head (aa7d354).

Additional details and impacted files 
@@                  Coverage Diff                  @@
##           debugging_feature    #5749      +/-   ##
=====================================================
+ Coverage              99.66%   99.67%   +0.01%     
=====================================================
  Files                    414      414              
  Lines                  39234    39241       +7     
=====================================================
+ Hits                   39101    39112      +11     
+ Misses                   133      129       -4

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Jaybsoni and others added 3 commits June 4, 2024 15:52
@Jaybsoni
expand state to device wires
3f9585d
@Jaybsoni @Mandrenkov
Apply suggestions from code review
13f55f0 
Co-authored-by: Mikhail Andrenkov <mikhail@xanadu.ai>
@Jaybsoni
[skip ci]
18b75df 
Merge branch 'debugging_feature' into algo_debug_breakpoint
@Jaybsoni Jaybsoni mentioned this pull request Jun 5, 2024
Merged
@Jaybsoni Jaybsoni added review-ready 👌 PRs which are ready for review by someone from the core team. and removed WIP 🚧 Work-in-progress labels Jun 5, 2024
Base automatically changed from algo_debug_breakpoint to debugging_feature June 6, 2024 02:33
soranjh
soranjh requested changes Jun 6, 2024
View reviewed changes
Copy link
Contributor

@soranjh soranjh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @Jaybsoni, looks good overall, left some comments.

pennylane/debugging.py Outdated Show resolved Hide resolved
pennylane/debugging.py Outdated Show resolved Hide resolved
pennylane/debugging.py Show resolved Hide resolved
pennylane/debugging.py Outdated Show resolved Hide resolved
pennylane/debugging.py Show resolved Hide resolved
tests/test_debugging.py Show resolved Hide resolved
tests/test_debugging.py Show resolved Hide resolved
@Jaybsoni Jaybsoni requested a review from soranjh June 6, 2024 18:00
soranjh
soranjh approved these changes Jun 6, 2024
View reviewed changes
Copy link
Contributor

@soranjh soranjh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @Jaybsoni, looks all good to me.

obliviateandsurrender
obliviateandsurrender reviewed Jun 6, 2024
View reviewed changes
Copy link
Contributor

@obliviateandsurrender obliviateandsurrender left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @Jaybsoni, looking great! Leaving some suggestions.

pennylane/debugging.py Outdated Show resolved Hide resolved
pennylane/debugging.py Outdated Show resolved Hide resolved
tests/test_debugging.py Outdated Show resolved Hide resolved
pennylane/debugging.py Show resolved Hide resolved
pennylane/debugging.py Show resolved Hide resolved
obliviateandsurrender
obliviateandsurrender approved these changes Jun 7, 2024
View reviewed changes
Copy link
Contributor

@obliviateandsurrender obliviateandsurrender left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM ☘️

@Jaybsoni Jaybsoni merged commit cf7e012 into debugging_feature Jun 7, 2024
39 checks passed
@Jaybsoni Jaybsoni deleted the algo_debug_measurements branch June 7, 2024 14:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@obliviateandsurrender obliviateandsurrender obliviateandsurrender approved these changes

@soranjh soranjh soranjh approved these changes

@DSGuala DSGuala Awaiting requested review from DSGuala

Assignees
No one assigned
Labels
review-ready 👌 PRs which are ready for review by someone from the core team.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@Jaybsoni @obliviateandsurrender @soranjh