Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve variable names for QutritAmplitudeDamping channel #5799

Conversation

Gabriel-Bottrill
Copy link
Contributor

@Gabriel-Bottrill Gabriel-Bottrill commented Jun 4, 2024

Context:
The QutritAmplitudeDamping channel #5503 and #5757 variable names are named with numbers, when making the TritFlip channel #5784 I realized that it would be better to specify subspaces for clarity. This PR is meant to change the name of QutritAmplitudeDamping's variables.

Description of the Change:
Change the name of the QutritAmplitudeDamping channel's variables from gamma_1, gamma_2, and gamma_3 to gamma_01, gamma_02, and gamma_12, respectively.

Benefits:
Makes the code more clear for which variables affect which subspace, reducing the need to check the docs.

Possible Drawbacks:
Changes the name of variables of development code.

Related GitHub Issues:
N/A

@Gabriel-Bottrill Gabriel-Bottrill changed the title Fixed variable names for channel Improve variable names for QutritAmplitudeDamping channel Jun 4, 2024
@Gabriel-Bottrill Gabriel-Bottrill marked this pull request as ready for review June 4, 2024 22:54
@Gabriel-Bottrill Gabriel-Bottrill mentioned this pull request Jun 4, 2024
@Gabriel-Bottrill
Copy link
Contributor Author

Hi @albi3ro, @glassnotes, @mudit2812, and @trbromley; @glassnotes pointed out that I should fix the names of QutritAmplitudeDamping gamma to specify the subspace, this PR does this.

Copy link

codecov bot commented Jun 4, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 99.66%. Comparing base (7384db3) to head (7725ff5).

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #5799      +/-   ##
==========================================
- Coverage   99.66%   99.66%   -0.01%     
==========================================
  Files         414      414              
  Lines       39490    39194     -296     
==========================================
- Hits        39359    39061     -298     
- Misses        131      133       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

pennylane/ops/qutrit/channel.py Outdated Show resolved Hide resolved
@glassnotes glassnotes merged commit 087c1c8 into PennyLaneAI:master Jun 6, 2024
40 checks passed
@Gabriel-Bottrill Gabriel-Bottrill deleted the qutrit_amplitude_dampening_gamma_indices branch June 6, 2024 07:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants