Added jax support to private function _qsp_to_qsvt() which handles convention changes.
#5853
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hello. You may have forgotten to update the changelog!
|
soranjh
approved these changes
Jun 13, 2024
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #5853 +/- ##
==========================================
- Coverage 99.67% 99.66% -0.01%
==========================================
Files 425 425
Lines 40751 40457 -294
==========================================
- Hits 40618 40323 -295
- Misses 133 134 +1 ☔ View full report in Codecov by Sentry. |
dime10
reviewed
Jun 13, 2024
Co-authored-by: David Ittah <dime10@users.noreply.github.com>
soranjh
approved these changes
Jun 21, 2024
mudit2812
pushed a commit
that referenced
this pull request
Jul 2, 2024
…convention changes. (#5853) **Context:** Allow for `qml.qsvt()` to accept phase angles as jax arrays and perform convention conversions. --------- Co-authored-by: David Ittah <dime10@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context:
Allow for
qml.qsvt()to accept phase angles as jax arrays and perform convention conversions.