Incorporate level keyword in draw and draw_mpl
#5855
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hello. You may have forgotten to update the changelog!
|
mudit2812
reviewed
Jun 14, 2024
mudit2812
requested changes
Jun 14, 2024
There was a problem hiding this comment.
Looks good @Shiro-Raven 🎉 ! I don't consider the comments in this review to be blocking. I'll approve once tests are passing.
Co-authored-by: Mudit Pandey <mudit.pandey@xanadu.ai>
trbromley
reviewed
Jun 18, 2024
…nd PT * Fix `specs` tests relating to `trainable_params` fix * Fix bug in PyTorch's `constuct`
Co-authored-by: Thomas R. Bromley <49409390+trbromley@users.noreply.github.com>
Co-authored-by: Thomas R. Bromley <49409390+trbromley@users.noreply.github.com>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #5855 +/- ##
==========================================
+ Coverage 99.43% 99.66% +0.23%
==========================================
Files 421 421
Lines 41191 40309 -882
==========================================
- Hits 40958 40175 -783
+ Misses 233 134 -99 ☔ View full report in Codecov by Sentry. |
mudit2812
reviewed
Jun 19, 2024
|
Looks like there's some code cov failures. Seems like some of the code in the |
albi3ro
reviewed
Jun 19, 2024
mudit2812
added a commit
that referenced
this pull request
Jul 2, 2024
**Context:** Currently, `draw()` and `draw_mpl()` can only be requested after applying the full transform program, with the exception of the stages provided through expansion_strategy. **Description of the Change:** Using the new `level` argument from construct_batch, the functions are adapted to make use of the argument as well, which allows for more flexible requests and ability to pinpoint where exactly in the transform program to draw a circuit. As done before, the new functionality works with transforms that split the tape (only in the case for `draw`. For `draw_mpl`, a warning is raised and only the first tape is plotted). **Benefits:** Better plotting UX. **Note for Reviewers:** Minor bugs in `construct_batch` have been discovered during work on this PR, and so expect minor fixes to tests relating to `specs`. [[sc-53735](https://app.shortcut.com/xanaduai/story/53735)] Supersedes #5139 --------- Co-authored-by: Mudit Pandey <mudit.pandey@xanadu.ai> Co-authored-by: Thomas R. Bromley <49409390+trbromley@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context:
Currently,
draw()anddraw_mpl()can only be requested after applying the full transform program, with the exception of the stages provided through expansion_strategy.Description of the Change:
Using the new
levelargument from construct_batch, the functions are adapted to make use of the argument as well, which allows for more flexible requests and ability to pinpoint where exactly in the transform program to draw a circuit. As done before, the new functionality works with transforms that split the tape (only in the case fordraw. Fordraw_mpl, a warning is raised and only the first tape is plotted).Benefits:
Better plotting UX.
Note for Reviewers:
Minor bugs in
construct_batchhave been discovered during work on this PR, and so expect minor fixes to tests relating tospecs.[sc-53735] Supersedes #5139