Adding known Quantum channels #766
Conversation
There was a problem hiding this comment.
Looking really neat @AroosaIjaz! Note that I haven't approved/requested changes since this is still a draft PR
| class TestChannels: | ||
| """Tests for the quantum channels""" | ||
|
|
||
| @pytest.mark.parametrize("ops", ch_list) |
There was a problem hiding this comment.
Tests look good!
I would suggest performing the tests for more than one parameter value, which can be easily done with parametrize and defining the expected outputs outside of the test themselves
There was a problem hiding this comment.
Looks good to me! 🚀 Nice one @AroosaIjaz
Something seems to be going on with the probability tests.
… channel_examples
… channel_examples
|
This is ready for a final review :) |
AroosaIjaz
added
the
review-ready 👌
There was a problem hiding this comment.
@AroosaIjaz I suggested fixing some of the merge issues due to #760 being merged, before this is ready for final review!
Thank you @josh146, I am on it! :) |
| "AmplitudeDamping", | ||
| "GeneralizedAmplitudeDamping", | ||
| "PhaseDamping", | ||
| "DepolarizingChannel", |
There was a problem hiding this comment.
Future additions could be bit flip noise 👍
There was a problem hiding this comment.
I can add it in this PR too. What do you say? It was taken out in the ADR review process so I did not add it.
|
I think the tests aren't working due to line 887 in |
Co-authored-by: Tom Bromley <49409390+trbromley@users.noreply.github.com>
Co-authored-by: Tom Bromley <49409390+trbromley@users.noreply.github.com>
Co-authored-by: Tom Bromley <49409390+trbromley@users.noreply.github.com>
Co-authored-by: Tom Bromley <49409390+trbromley@users.noreply.github.com>
Co-authored-by: Tom Bromley <49409390+trbromley@users.noreply.github.com>
Codecov Report
@@ Coverage Diff @@
## master #766 +/- ##
==========================================
+ Coverage 93.42% 93.52% +0.09%
==========================================
Files 115 116 +1
Lines 7044 7099 +55
==========================================
+ Hits 6581 6639 +58
+ Misses 463 460 -3
Continue to review full report at Codecov.
|
Co-authored-by: Josh Izaac <josh146@gmail.com>
|
@josh146 I might need your help merging this as the codecov is not responding. Thank you! After this is merged, I will make the final merge checks on 778 and merge that in too :) |
Context:
ADR 240: Adding quantum channels to PennyLane
Description of the Change:
This PR adds known noisy channels, provides corresponding tests, and updates the introduction page on PennyLane operations.