Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hard time packaging sippts #4

Closed
noraj opened this issue May 9, 2019 · 2 comments
Closed

Hard time packaging sippts #4

noraj opened this issue May 9, 2019 · 2 comments

Comments

@noraj
Copy link

noraj commented May 9, 2019

We have a hard time packaging sippts for BlackArch. See #2336.

The right packaging standard is to put the app data under /usr/share/sippts/ and then create a wrapper in /usr/bin/sipscan to have the tool available. We packaged it like this in the first place.

As you can see in #2336 the problem is that the script is looking for the database in the working directory. It would be cleaner and easier to package if sippts was using a configuration file (that could stay in /usr/share/sippts/ or in ~/.config/sippts) where the database path is specified. Also system("cp $database_empty $database") if (! -e $database); should be removed so this would be done by the package that would copy the empty db to ~/.config/sippts at installation (users that want to git clone and use the tool independently can still copy the db manually wherever they want).

@Pepelux
Copy link
Owner

Pepelux commented May 9, 2019

Fixed

Commit: 128520e

@Pepelux Pepelux closed this as completed May 9, 2019
@noraj
Copy link
Author

noraj commented May 9, 2019

@Pepelux Thanks, that was very quick.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants